Aksal/nuttx
3
1
Fork 1
mirror of https://github.com/apache/nuttx.git synced 2026-08-01 20:28:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

openamp: optimize virtqueue_notification() called condition

Browse source 
1. call virtqueue_notification() only when buffer exist to avoid unnecessary
calls to virtqueue callback.

2. call virtqueue_notification() only when vq != NULL, because
rproc_virtio_notified() may be called when the virtqueues is not created:
virtqueue created in the virtio/vhost driver but the virtio devices
has been added to the remoteproc virtio devices list after the remoteproc
transport layer create the virtio devices.

Signed-off-by: Bowen Wang <wangbowen6@xiaomi.com>
This commit is contained in:
Bowen Wang 2026-01-15 16:54:19 +08:00 • committed by GUIDINGLI
parent 143c5715c0
commit 1fa6a43a40
3 changed files with 57 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

54
openamp/0015-lib-remoteproc_virtio-optimize-virtqueue_notificatio.patch Normal file
View file

@ -0,0 +1,54 @@
From ab744079b1c9905a06a0f235bbfb852a83aa20d3 Mon Sep 17 00:00:00 2001
From: Bowen Wang <wangbowen6@xiaomi.com>
Date: Thu, 21 Nov 2024 16:53:11 +0800
Subject: [PATCH 15/15] lib/remoteproc_virtio: optimize
virtqueue_notification() called condition
1. call virtqueue_notification() only when buffer exist to avoid unnecessary
calls to virtqueue callback.
2. call virtqueue_notification() only when vq != NULL, because
rproc_virtio_notified() may be called when the virtqueues is not created:
virtqueue created in the virtio/vhost driver but the virtio devices
has been added to the remoteproc virtio devices list after the remoteproc
transport layer create the virtio devices.
Signed-off-by: Bowen Wang <wangbowen6@xiaomi.com>
---
lib/remoteproc/remoteproc_virtio.c | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/lib/remoteproc/remoteproc_virtio.c open-amp/lib/remoteproc/remoteproc_virtio.c
index 7dee1354e0..2470454377 100644
--- a/lib/remoteproc/remoteproc_virtio.c
+++ open-amp/lib/remoteproc/remoteproc_virtio.c
@@ -403,6 +403,7 @@ int rproc_virtio_notified(struct virtio_device *vdev, uint32_t notifyid)
unsigned int num_vrings, i;
struct virtio_vring_info *vring_info;
struct virtqueue *vq;
+ bool notify;
if (!vdev)
return -RPROC_EINVAL;
@@ -412,9 +413,15 @@ int rproc_virtio_notified(struct virtio_device *vdev, uint32_t notifyid)
num_vrings = vdev->vrings_num;
for (i = 0; i < num_vrings; i++) {
vring_info = &vdev->vrings_info[i];
- if (vring_info->notifyid == notifyid ||
- notifyid == RSC_NOTIFY_ID_ANY) {
- vq = vring_info->vq;
+ vq = vring_info->vq;
+ if (!vq)
+ continue;
+ if (vdev->role == VIRTIO_DEV_DRIVER)
+ notify = virtqueue_nused(vq) > 0;
+ else
+ notify = virtqueue_navail(vq) > 0;
+ if (notify && (vring_info->notifyid == notifyid ||
+ notifyid == RSC_NOTIFY_ID_ANY)) {
virtqueue_notification(vq);
}
}
--
2.34.1

2
openamp/open-amp.cmake
View file

@ -66,6 +66,8 @@ if(NOT EXISTS ${CMAKE_CURRENT_LIST_DIR}/open-amp)
${CMAKE_CURRENT_LIST_DIR}/0013-virtio.h-add-mm_priv-to-struct-virtio_deivce.patch
&& patch -p0 -d ${CMAKE_CURRENT_LIST_DIR} <
${CMAKE_CURRENT_LIST_DIR}/0014-lib-rpmsg_virtio-use-virtio_alloc_buf-to-alloc-share.patch
&& patch -p0 -d ${CMAKE_CURRENT_LIST_DIR} <
${CMAKE_CURRENT_LIST_DIR}/0015-lib-remoteproc_virtio-optimize-virtqueue_notificatio.patch
DOWNLOAD_NO_PROGRESS true
TIMEOUT 30)

1
openamp/open-amp.defs
View file

@ -80,6 +80,7 @@ open-amp.zip:
$(Q) patch -p0 < 0012-remoteproc-sync-the-virtio-rpmsg-config-with-linux-s.patch
$(Q) patch -p0 < 0013-virtio.h-add-mm_priv-to-struct-virtio_deivce.patch
$(Q) patch -p0 < 0014-lib-rpmsg_virtio-use-virtio_alloc_buf-to-alloc-share.patch
$(Q) patch -p0 < 0015-lib-remoteproc_virtio-optimize-virtqueue_notificatio.patch
.openamp_headers: open-amp.zip
else