mirror of
https://github.com/apache/nuttx.git
synced 2026-08-18 20:18:17 +00:00
When the 'c' parameter has bit 7 set (e.g. 0x80), the int value gets sign extended (to 0xffffff80 on the signed char platforms). The word sized fill pattern was built without truncating to unsigned char first, so the fast word aligned path wrote the wrong bytes. Fix both lib_memset.c and lib_bsdmemset.c by casting 'c' to unsigned char before building the fill pattern, as required by C11 7.24.6.1 which states that memset converts 'c' to unsigned char. Assisted-by: Claude:claude-opus-5 Signed-off-by: Bowen Wang <wangbowen6@xiaomi.com>
194 lines
5.7 KiB
C
194 lines
5.7 KiB
C
/****************************************************************************
|
|
* libs/libc/string/lib_memset.c
|
|
*
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*
|
|
* Licensed to the Apache Software Foundation (ASF) under one or more
|
|
* contributor license agreements. See the NOTICE file distributed with
|
|
* this work for additional information regarding copyright ownership. The
|
|
* ASF licenses this file to you under the Apache License, Version 2.0 (the
|
|
* "License"); you may not use this file except in compliance with the
|
|
* License. You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
* License for the specific language governing permissions and limitations
|
|
* under the License.
|
|
*
|
|
****************************************************************************/
|
|
|
|
/****************************************************************************
|
|
* Included Files
|
|
****************************************************************************/
|
|
|
|
#include <nuttx/config.h>
|
|
|
|
#include <sys/types.h>
|
|
|
|
#include <stdint.h>
|
|
#include <string.h>
|
|
#include <assert.h>
|
|
|
|
#include "libc.h"
|
|
|
|
/****************************************************************************
|
|
* Public Functions
|
|
****************************************************************************/
|
|
|
|
#if !defined(CONFIG_LIBC_ARCH_MEMSET) && defined(LIBC_BUILD_MEMSET)
|
|
#undef memset
|
|
no_builtin("memset")
|
|
FAR void *memset(FAR void *s, int c, size_t n)
|
|
{
|
|
#ifdef CONFIG_LIBC_MEMSET_OPTSPEED
|
|
/* This version is optimized for speed (you could do better
|
|
* still by exploiting processor caching or memory burst
|
|
* knowledge.)
|
|
*/
|
|
|
|
uintptr_t addr = (uintptr_t)s;
|
|
uint8_t val8 = (uint8_t)c;
|
|
uint16_t val16 = ((uint16_t)val8 << 8) | (uint16_t)val8;
|
|
uint32_t val32 = ((uint32_t)val16 << 16) | (uint32_t)val16;
|
|
#ifdef CONFIG_LIBC_MEMSET_64BIT
|
|
uint64_t val64 = ((uint64_t)val32 << 32) | (uint64_t)val32;
|
|
#endif
|
|
|
|
/* Make sure that there is something to be cleared */
|
|
|
|
if (n > 0)
|
|
{
|
|
/* Align to a 16-bit boundary */
|
|
|
|
if ((addr & 1) != 0)
|
|
{
|
|
*(FAR uint8_t *)addr = (uint8_t)c;
|
|
addr += 1;
|
|
n -= 1;
|
|
}
|
|
|
|
/* Check if there are at least 16-bits left to be written */
|
|
|
|
if (n >= 2)
|
|
{
|
|
/* Align to a 32-bit boundary (we know that the destination
|
|
* address is already aligned to at least a 16-bit boundary).
|
|
*/
|
|
|
|
if ((addr & 3) != 0)
|
|
{
|
|
*(FAR uint16_t *)addr = val16;
|
|
addr += 2;
|
|
n -= 2;
|
|
}
|
|
|
|
#ifndef CONFIG_LIBC_MEMSET_64BIT
|
|
/* Loop while there are at least 16-bytes left to be written */
|
|
|
|
while (n >= 16)
|
|
{
|
|
*(FAR uint32_t *)(addr + 0) = val32;
|
|
*(FAR uint32_t *)(addr + 4) = val32;
|
|
*(FAR uint32_t *)(addr + 8) = val32;
|
|
*(FAR uint32_t *)(addr + 12) = val32;
|
|
addr += 16;
|
|
n -= 16;
|
|
}
|
|
|
|
/* Loop while there are at least 32-bits left to be written */
|
|
|
|
while (n >= 4)
|
|
{
|
|
*(FAR uint32_t *)addr = val32;
|
|
addr += 4;
|
|
n -= 4;
|
|
}
|
|
#else
|
|
/* Check if there are at least 32-bits left to be written */
|
|
|
|
if (n >= 4)
|
|
{
|
|
/* Align to a 64-bit boundary (we know that the destination
|
|
* address is already aligned to at least a 32-bit boundary).
|
|
*/
|
|
|
|
if ((addr & 7) != 0)
|
|
{
|
|
*(FAR uint32_t *)addr = val32;
|
|
addr += 4;
|
|
n -= 4;
|
|
}
|
|
|
|
/* Loop while there are at least 64-bytes left to be written */
|
|
|
|
while (n >= 64)
|
|
{
|
|
*(FAR uint64_t *)(addr + 0) = val64;
|
|
*(FAR uint64_t *)(addr + 8) = val64;
|
|
*(FAR uint64_t *)(addr + 16) = val64;
|
|
*(FAR uint64_t *)(addr + 24) = val64;
|
|
*(FAR uint64_t *)(addr + 32) = val64;
|
|
*(FAR uint64_t *)(addr + 40) = val64;
|
|
*(FAR uint64_t *)(addr + 48) = val64;
|
|
*(FAR uint64_t *)(addr + 56) = val64;
|
|
addr += 64;
|
|
n -= 64;
|
|
}
|
|
|
|
/* Loop while there are at least 64-bits left to be written */
|
|
|
|
while (n >= 8)
|
|
{
|
|
*(FAR uint64_t *)addr = val64;
|
|
addr += 8;
|
|
n -= 8;
|
|
}
|
|
}
|
|
#endif
|
|
}
|
|
|
|
#ifdef CONFIG_LIBC_MEMSET_64BIT
|
|
/* We may get here with n in the range 0..7. If n >= 4, then we should
|
|
* have 64-bit alignment.
|
|
*/
|
|
|
|
if (n >= 4)
|
|
{
|
|
*(FAR uint32_t *)addr = val32;
|
|
addr += 4;
|
|
n -= 4;
|
|
}
|
|
#endif
|
|
|
|
/* We may get here under the following conditions:
|
|
*
|
|
* n = 0, addr may or may not be aligned
|
|
* n = 1, addr is aligned to at least a 16-bit boundary
|
|
* n = 2, addr is aligned to a 32-bit boundary
|
|
* n = 3, addr is aligned to a 32-bit boundary
|
|
*/
|
|
|
|
if (n >= 2)
|
|
{
|
|
*(FAR uint16_t *)addr = val16;
|
|
addr += 2;
|
|
n -= 2;
|
|
}
|
|
|
|
if (n >= 1)
|
|
{
|
|
*(FAR uint8_t *)addr = (uint8_t)c;
|
|
}
|
|
}
|
|
#else
|
|
/* This version is optimized for size */
|
|
|
|
FAR unsigned char *p = (FAR unsigned char *)s;
|
|
while (n-- > 0) *p++ = c;
|
|
#endif
|
|
return s;
|
|
}
|
|
#endif
|