mirror of
https://github.com/apache/nuttx.git
synced 2026-08-16 01:43:15 +00:00
60a8ddad79
* According to strdup(3) manual strdup() allocates memory with malloc(3) and that memory should be released with free(3) when no longer needed. * For non existent path or file open error mkversion used exit() with no prior free() for allocated memory. * This change introduces ret variable, exit label, and free on exit in order to avoid potential memory leak. * tools/mkversion is a tiny short-lived utility and the memory gets freed by the OS upon application termination so that was not a bit issue, but now memory leak scanners should be happy as we have free() in pair to strdup(). Reported-by: xjDeng. Signed-off-by: Tomasz 'CeDeROM' CEDRO <tomek@cedro.info>
101 lines
3.1 KiB
C
101 lines
3.1 KiB
C
/****************************************************************************
|
|
* tools/mkversion.c
|
|
*
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*
|
|
* Licensed to the Apache Software Foundation (ASF) under one or more
|
|
* contributor license agreements. See the NOTICE file distributed with
|
|
* this work for additional information regarding copyright ownership. The
|
|
* ASF licenses this file to you under the Apache License, Version 2.0 (the
|
|
* "License"); you may not use this file except in compliance with the
|
|
* License. You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
* License for the specific language governing permissions and limitations
|
|
* under the License.
|
|
*
|
|
****************************************************************************/
|
|
|
|
/****************************************************************************
|
|
* Included Files
|
|
****************************************************************************/
|
|
|
|
#include <string.h>
|
|
#include <stdlib.h>
|
|
#include <errno.h>
|
|
|
|
#include "cfgdefine.h"
|
|
|
|
/****************************************************************************
|
|
* Pre-processor Definitions
|
|
****************************************************************************/
|
|
|
|
#define DEFCONFIG ".version"
|
|
|
|
/****************************************************************************
|
|
* Private Functions
|
|
****************************************************************************/
|
|
|
|
static inline char *getfilepath(const char *name)
|
|
{
|
|
snprintf(line, PATH_MAX, "%s/" DEFCONFIG, name);
|
|
line[PATH_MAX] = '\0';
|
|
return strdup(line);
|
|
}
|
|
|
|
static void show_usage(const char *progname)
|
|
{
|
|
fprintf(stderr, "USAGE: %s <abs path to .version>\n", progname);
|
|
}
|
|
|
|
/****************************************************************************
|
|
* Public Functions
|
|
****************************************************************************/
|
|
|
|
int main(int argc, char **argv, char **envp)
|
|
{
|
|
char *filepath;
|
|
FILE *stream;
|
|
int ret = 0;
|
|
|
|
if (argc != 2)
|
|
{
|
|
fprintf(stderr, "Unexpected number of arguments\n");
|
|
show_usage(argv[0]);
|
|
exit(1);
|
|
}
|
|
|
|
filepath = getfilepath(argv[1]);
|
|
if (filepath == NULL)
|
|
{
|
|
fprintf(stderr, "getfilepath failed\n");
|
|
ret = 2;
|
|
goto exit;
|
|
}
|
|
|
|
stream = fopen(filepath, "r");
|
|
if (stream == NULL)
|
|
{
|
|
fprintf(stderr, "open %s failed: %s\n", filepath, strerror(errno));
|
|
ret = 3;
|
|
goto exit;
|
|
}
|
|
|
|
printf("/* version.h -- Autogenerated! Do not edit. */\n\n");
|
|
printf("#ifndef __INCLUDE_NUTTX_VERSION_H\n");
|
|
printf("#define __INCLUDE_NUTTX_VERSION_H\n\n");
|
|
generate_definitions(stream);
|
|
printf("\n#define CONFIG_VERSION ((CONFIG_VERSION_MAJOR << 16) |\\\n"
|
|
" (CONFIG_VERSION_MINOR << 8) |\\\n"
|
|
" (CONFIG_VERSION_PATCH))\n\n");
|
|
printf("#endif /* __INCLUDE_NUTTX_VERSION_H */\n");
|
|
fclose(stream);
|
|
|
|
exit:
|
|
free(filepath);
|
|
return ret;
|
|
}
|