mirror of
https://github.com/apache/nuttx.git
synced 2026-10-11 08:10:21 +00:00
d8deca6c52
Fix a potential deadlock in the DMA driver. DMA completion callbacks
may immediately submit another transfer, for example:
imx9_dmaterminate()
-> imx9_dma_txcallback()
-> imx9_dma_txavailable()
-> uart_xmitchars_dma()
-> imx9_dma_send()
-> imx9_dmach_stop()
-> imx9_dmaterminate()
Resulting dmaterminate to take the same spinlock again. Fix this by moving
the spin_unlock_irqrestore_nopreempt before calling the callback. It is not
necessary to keep dma channel locked during the callback; the channel is
already free at this point.
This doesn't directly affect arch/arm/imx9 (the cortex-m version) because
it is not SMP (the spinlock is reduced to blocking irqs), but it is worth
fixing at the same to keep drivers in sync.
Signed-off-by: Jukka Laitinen <jukka.laitinen@tii.ae>
|
||
|---|---|---|
| .. | ||
| a64 | ||
| a527 | ||
| am62x | ||
| bcm2711 | ||
| cmake | ||
| common | ||
| fvp-v8r | ||
| goldfish | ||
| imx8 | ||
| imx9 | ||
| qemu | ||
| rk3399 | ||
| rk3588 | ||
| zynq-mpsoc | ||
| .gitignore | ||
| CMakeLists.txt | ||
| Makefile | ||
| Toolchain.defs | ||