mirror of
https://github.com/apache/nuttx.git
synced 2026-08-10 06:55:13 +00:00
cda33ae4fc
dns_recv_response() checked for room using sizeof(struct dns_answer_s), but that structure is the 10-byte header plus a union holding the largest address it can carry. With IPv6 built the union is 16 bytes, so the check demanded 26 bytes where 10 were needed, and any answer sitting at the end of a response was rejected as truncated. An A record answer supplies 14 bytes, so whether a lookup worked depended on how much padding the server happened to send after it: $ dig +noedns @10.1.1.2 github.com A # ANSWER 1, AUTHORITY 0, ADDITIONAL 0 -> answer is last in the packet, 14 bytes remain, rejected $ dig +noedns @10.11.5.254 github.com A # ANSWER 1, AUTHORITY 13, ADDITIONAL 7 -> 26+ bytes remain, accepted On the board, before and after, against the first of those servers: nsh> nslookup apache.org [CPU1] dns_recv_response: DNS answer header truncated Host: apache.org Addr: 2a04:4e42::644 <- A record lost nsh> nslookup apache.org Host: apache.org Addr: 2a04:4e42::644 Host: apache.org Addr: 151.101.2.132 <- both returned The address that follows the header is already bounds checked separately, where its real length is known, so only the header check was wrong. The size is now a named constant next to the structure, since the rest of this function already used the literal 10 for the same quantity. Only IPv4-only builds escaped it, where sizeof happens to equal 14 and an A record fits exactly. Assisted-by: Claude:claude-opus-5 Signed-off-by: Justin Hammond <justin@dynam.ac> |
||
|---|---|---|
| .. | ||
| CMakeLists.txt | ||
| Kconfig | ||
| lib_dn.c | ||
| lib_dns.h | ||
| lib_dnsaddserver.c | ||
| lib_dnsbind.c | ||
| lib_dnscache.c | ||
| lib_dnsdefaultserver.c | ||
| lib_dnsdelserver.c | ||
| lib_dnsforeach.c | ||
| lib_dnsinit.c | ||
| lib_dnsnotify.c | ||
| lib_dnsquery.c | ||
| lib_dnsqueryfamily.c | ||
| lib_freeaddrinfo.c | ||
| lib_gaistrerror.c | ||
| lib_getaddrinfo.c | ||
| lib_gethostbyaddr.c | ||
| lib_gethostbyaddrr.c | ||
| lib_gethostbyname.c | ||
| lib_gethostbyname2.c | ||
| lib_gethostbyname2r.c | ||
| lib_gethostbynamer.c | ||
| lib_gethostentbynamer.c | ||
| lib_getnameinfo.c | ||
| lib_getservbyname.c | ||
| lib_getservbynamer.c | ||
| lib_getservbyport.c | ||
| lib_getservbyportr.c | ||
| lib_netdb.c | ||
| lib_netdb.h | ||
| lib_parsehostfile.c | ||
| lib_proto.c | ||
| lib_protor.c | ||
| lib_rexec.c | ||
| Make.defs | ||