mirror of
https://github.com/apache/nuttx.git
synced 2026-08-05 22:29:02 +00:00
689ed188c6
While attempting to create architecture-specific implementation of up_udelay, it was discovered that the overriding function is not included in the final binary, the weak implementation was used instead. Further investigation and experimentation showed that the linker only overrides the weak implementation with the custom one if the custom one is present in a .c source file that contains at least one other function that is called from somewhere. Some additional testing revealed that at least one other already present up_udelay override (rv32m1-vega:nsh) is affected by this. In a short mailing list discussion it was determined that this is a likely result of using static libraries during the build process and it was suggested to introduce configuration option that will exclude weak implementations of the function from the build altogether. This patch does that. This patch does not enable this configuration option for any existing board/chip because doing so would change its behaviour and needs to be tested by users of the hardware. Also changed is the static assertion in sched/clock/clock_delay.c to not prevent building the code when architecture declares that it does not use BOARD_LOOPSPERMSEC to determine required loop count. BOARD_LOOPSPERMSEC is made undefined in such case. Patch was tested by building breadxavr:nsh (identical binary by SHA256), rv32m1-vega:nsh (identical text section) and rv-virt:nsh (text section differs because of different ordering of functions in the binary, ostest passed though.) Signed-off-by: Kerogit <kr.git@kerogit.eu> |
||
|---|---|---|
| .. | ||
| clock.c | ||
| clock.h | ||
| clock_adjtime.c | ||
| clock_delay.c | ||
| clock_getres.c | ||
| clock_gettime.c | ||
| clock_initialize.c | ||
| clock_notifier.c | ||
| clock_perf.c | ||
| clock_realtime2absticks.c | ||
| clock_sched_ticks.c | ||
| clock_settime.c | ||
| clock_systime_ticks.c | ||
| clock_systime_timespec.c | ||
| clock_timekeeping.c | ||
| clock_timekeeping.h | ||
| CMakeLists.txt | ||
| Make.defs | ||