mirror of
https://github.com/apache/nuttx.git
synced 2026-10-05 13:17:49 +00:00
14fb39a6cd
The elf_emit() function in coredump.c was only checking for negative returnvalues from lib_stream_puts() to detect write failures. However, lib_stream_puts()can return 0 to indicate that no bytes were written (e.g., due to stream full,end-of-file, or other non-error conditions that prevent data writing). This oversight meant that cases where lib_stream_puts() returned 0 would bypassthe error handling, leading to incomplete data emission in the core dump withoutany failure indication. The loop would continue attempting to write the remainingdata, resulting in partial or corrupted core dump files. This fix modifies the condition from ret < 0 to ret <= 0 to: 1. Catch both error conditions (negative return values) and zero-byte writes. 2. Immediately break the write loop and propagate the failure, ensuring the core dump process correctly aborts when data cannot be written. This change improves the reliability of core dump generation by ensuring allfailed or incomplete write attempts are properly handled, preventing corruptedcore dump files. Signed-off-by: chao an <anchao.archer@bytedance.com> |
||
|---|---|---|
| .. | ||
| assert.c | ||
| CMakeLists.txt | ||
| coredump.c | ||
| coredump.h | ||
| deadlock.c | ||
| Make.defs | ||
| panic_notifier.c | ||
| reboot_notifier.c | ||