From fbe3468703fe34238f5da9e2df1fb89b7ebf5d9d Mon Sep 17 00:00:00 2001 From: Jacob Dahl Date: Sun, 30 Aug 2026 14:38:00 -0600 Subject: [PATCH] arch/arm/src/stm32h7: Remove broken FDCAN filter ioctl stubs. The SIOCxCANxxFILTER cases in fdcan_netdev_ioctl() call stm32_addextfilter(), stm32_delextfilter(), stm32_addstdfilter() and stm32_delstdfilter(), none of which exist anywhere in the tree. The block only ever compiled because no stm32h7 config enables NETDEV_CAN_FILTER_IOCTL; enabling it breaks the link. The commands now fall through to the existing -ENOTSUP default, which is also what a caller observed before. Assisted-by: Claude:claude-fable-5 Signed-off-by: Jacob Dahl --- arch/arm/src/stm32h7/stm32_fdcan_sock.c | 34 ------------------------- 1 file changed, 34 deletions(-) diff --git a/arch/arm/src/stm32h7/stm32_fdcan_sock.c b/arch/arm/src/stm32h7/stm32_fdcan_sock.c index 15eecf55a7e..8585bc01d37 100644 --- a/arch/arm/src/stm32h7/stm32_fdcan_sock.c +++ b/arch/arm/src/stm32h7/stm32_fdcan_sock.c @@ -1987,40 +1987,6 @@ static int fdcan_netdev_ioctl(struct net_driver_s *dev, int cmd, break; #endif /* CONFIG_NETDEV_CAN_BITRATE_IOCTL */ -#ifdef CONFIG_NETDEV_CAN_FILTER_IOCTL - case SIOCACANEXTFILTER: - { - /* TODO: Add hardware-level filter... */ - - stm32_addextfilter(priv, (struct canioc_extfilter_s *)arg); - } - break; - - case SIOCDCANEXTFILTER: - { - /* TODO: Delete hardware-level filter... */ - - stm32_delextfilter(priv, (struct canioc_extfilter_s *)arg); - } - break; - - case SIOCACANSTDFILTER: - { - /* TODO: Add hardware-level filter... */ - - stm32_addstdfilter(priv, (struct canioc_stdfilter_s *)arg); - } - break; - - case SIOCDCANSTDFILTER: - { - /* TODO: Delete hardware-level filter... */ - - stm32_delstdfilter(priv, (struct canioc_stdfilter_s *)arg); - } - break; -#endif - default: ret = -ENOTSUP; break;