Aksal/nuttx
3
1
Fork 1
mirror of https://github.com/apache/nuttx.git synced 2026-08-14 17:03:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

arch/risc-v: fix uninitialized HW cmds and bus clock

Browse source 
Initialize i2c_ll_hw_cmd_t in sendstart/startrecv so ack_exp/done are
not left with stack garbage that can NACK or skip the address byte.
Program i2c_hal_set_bus_timing() with the requested bus_freq instead of
the board default so msg frequency is applied.

Affects only Espressif devices.

Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Filipe Cavalcanti <filipe.cavalcanti@espressif.com>
This commit is contained in:
Filipe Cavalcanti 2026-08-05 19:52:19 -03:00 • committed by Xiang Xiao
parent c191bcb76d
commit fb84ca4e4e
1 changed files with 26 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

40
arch/risc-v/src/common/espressif/esp_i2c.c
View file

@ -563,20 +563,25 @@ static void esp_i2c_sendstart(struct esp_i2c_priv_s *priv)
{
struct i2c_msg_s *msg = &priv->msgv[priv->msgid];
uint32_t fifo_val = 0;
i2c_ll_hw_cmd_t restart_cmd;
i2c_ll_hw_cmd_t write_cmd;
i2c_ll_hw_cmd_t end_cmd;
i2c_ll_hw_cmd_t restart_cmd =
{
.op_code = I2C_LL_CMD_RESTART
};
i2c_ll_hw_cmd_t write_cmd =
{
.byte_num = 1,
.ack_en = 1,
.op_code = I2C_LL_CMD_WRITE
};
i2c_ll_hw_cmd_t end_cmd =
{
.op_code = I2C_LL_CMD_END
};
/* Write I2C command registers */
restart_cmd.op_code = I2C_LL_CMD_RESTART;
write_cmd.byte_num = 1;
write_cmd.ack_en = 1;
write_cmd.op_code = I2C_LL_CMD_WRITE;
end_cmd.op_code = I2C_LL_CMD_END;
i2c_ll_master_write_cmd_reg(priv->ctx->dev, restart_cmd, 0);
i2c_ll_master_write_cmd_reg(priv->ctx->dev, write_cmd, 1);
i2c_ll_master_write_cmd_reg(priv->ctx->dev, end_cmd, 2);
@ -688,8 +693,15 @@ static void esp_i2c_startrecv(struct esp_i2c_priv_s *priv)
int ack_value = 0;
struct i2c_msg_s *msg = &priv->msgv[priv->msgid];
int n = msg->length - priv->bytes;
i2c_ll_hw_cmd_t read_cmd;
i2c_ll_hw_cmd_t end_cmd;
i2c_ll_hw_cmd_t read_cmd =
{
0
};
i2c_ll_hw_cmd_t end_cmd =
{
0
};
if (n > 1)
{
@ -780,7 +792,7 @@ static void esp_i2c_init_clock(struct esp_i2c_priv_s *priv,
I2C_CLOCK_SRC_ATOMIC()
{
i2c_hal_set_bus_timing(priv->ctx, priv->config->clk_freq,
i2c_hal_set_bus_timing(priv->ctx, bus_freq,
priv->clk_src, src_clk_frequency);
}