From cb6d78c9d177ae8b06c502f7df1095cdf7299d5e Mon Sep 17 00:00:00 2001 From: Masayuki Ishikawa Date: Thu, 21 Jan 2021 10:13:09 +0900 Subject: [PATCH] sched: sched: Remove sched_lock/unlock from nxsched_set_affinity() Summary: - Because this_task() and nxsched_get_tcb() are protected inside the funtcions - Also, enter_critical_section() is used in nxsched_set_affinity() Impact: - No impact Testing: - Tested with spresense:wifi_smp Signed-off-by: Masayuki Ishikawa --- sched/sched/sched_setaffinity.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sched/sched/sched_setaffinity.c b/sched/sched/sched_setaffinity.c index 813175f7516..2a9df0bbfe1 100644 --- a/sched/sched/sched_setaffinity.c +++ b/sched/sched/sched_setaffinity.c @@ -80,7 +80,6 @@ int nxsched_set_affinity(pid_t pid, size_t cpusetsize, /* Verify that the PID corresponds to a real task */ - sched_lock(); if (!pid) { tcb = this_task(); @@ -93,7 +92,7 @@ int nxsched_set_affinity(pid_t pid, size_t cpusetsize, if (tcb == NULL) { ret = -ESRCH; - goto errout_with_lock; + goto errout; } /* Don't permit changing the affinity mask of any task locked to a CPU @@ -143,8 +142,7 @@ int nxsched_set_affinity(pid_t pid, size_t cpusetsize, errout_with_csection: leave_critical_section(flags); -errout_with_lock: - sched_unlock(); +errout: return ret; }