Aksal/nuttx
3
1
Fork 1
mirror of https://github.com/apache/nuttx.git synced 2026-08-18 12:08:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

sched_profil.c: coverity HIS_metric_violation: RETURN

Browse source 
This change consolidates multiple return statements in the profil() function
into a single exit point by inverting the parameter validation condition and
restructuring error handling to reduce cyclomatic complexity and comply with MISRA HIS.

Signed-off-by: hujun5 <hujun5@xiaomi.com>
This commit is contained in:
hujun5 2025-08-13 13:21:17 +08:00 • committed by Donny(董九柱)
parent a06ac14988
commit c844ecf393
1 changed files with 26 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

47
sched/sched/sched_profil.c
View file

@ -142,30 +142,35 @@ int profil(FAR unsigned short *buf, size_t bufsiz,
FAR struct profinfo_s *prof = &g_prof;
irqstate_t flags;
uintptr_t highpc;
int ret = OK;
if (scale > 65536)
if (scale <= 65536)
{
if (buf != NULL && scale != 0)
{
memset(buf, 0, bufsiz);
highpc = (uintmax_t)bufsiz * 65536 / scale;
flags = spin_lock_irqsave(&prof->lock);
prof->counter = buf;
prof->lowpc = offset;
prof->highpc = offset + highpc;
prof->scale = scale;
spin_unlock_irqrestore(&prof->lock, flags);
wd_start(&prof->timer, PROFTICK, profil_timer_handler,
(wdparm_t)(uintptr_t)prof);
}
else
{
wd_cancel(&prof->timer);
}
}
else
{
set_errno(EINVAL);
return ERROR;
ret = ERROR;
}
if (buf == NULL || scale == 0)
{
wd_cancel(&prof->timer);
return OK;
}
memset(buf, 0, bufsiz);
highpc = (uintmax_t)bufsiz * 65536 / scale;
flags = spin_lock_irqsave(&prof->lock);
prof->counter = buf;
prof->lowpc = offset;
prof->highpc = offset + highpc;
prof->scale = scale;
spin_unlock_irqrestore(&prof->lock, flags);
wd_start(&prof->timer, PROFTICK, profil_timer_handler,
(wdparm_t)(uintptr_t)prof);
return OK;
return ret;
}