From abd769dcb0860f4b76941abf9d69a72f75caee23 Mon Sep 17 00:00:00 2001
From: YAMAMOTO Takashi <yamamoto@midokura.com>
Date: Tue, 26 Nov 2024 16:38:38 +0900
Subject: [PATCH] fs/littlefs: disable -Wshadow and explain why

---
 fs/littlefs/CMakeLists.txt | 4 ++++
 fs/littlefs/Make.defs      | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/fs/littlefs/CMakeLists.txt b/fs/littlefs/CMakeLists.txt
index 4ce674d781a..03f1821d5e6 100644
--- a/fs/littlefs/CMakeLists.txt
+++ b/fs/littlefs/CMakeLists.txt
@@ -61,6 +61,10 @@ if(CONFIG_FS_LITTLEFS)
             -DLFS_FILE_MAX=${CONFIG_FS_LITTLEFS_FILE_MAX}
             -DLFS_ATTR_MAX=${CONFIG_FS_LITTLEFS_ATTR_MAX})
 
+  # Note: the littlefs upstream doesn't seems to care -Wshadow cf.
+  # https://github.com/littlefs-project/littlefs/pull/873
+  target_compile_options(fs PRIVATE -Wno-shadow)
+
   target_sources(fs PRIVATE lfs_vfs.c ${CMAKE_CURRENT_LIST_DIR}/littlefs/lfs.c
                             ${CMAKE_CURRENT_LIST_DIR}/littlefs/lfs_util.c)
 
diff --git a/fs/littlefs/Make.defs b/fs/littlefs/Make.defs
index ae73a36f076..9a55eabf0f2 100644
--- a/fs/littlefs/Make.defs
+++ b/fs/littlefs/Make.defs
@@ -37,6 +37,10 @@ CSRCS += lfs.c lfs_util.c
 DEPPATH += --dep-path littlefs/littlefs
 VPATH += :littlefs/littlefs
 
+# Note: the littlefs upstream doesn't seems to care -Wshadow
+# cf. https://github.com/littlefs-project/littlefs/pull/873
+CFLAGS += -Wno-shadow
+
 CFLAGS += -DLFS_TRACE=finfo
 CFLAGS += -DLFS_DEBUG=finfo
 CFLAGS += -DLFS_WARN=fwarn