Aksal/nuttx
3
1
Fork 1
mirror of https://github.com/apache/nuttx.git synced 2026-08-01 20:28:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

arch/arm: nrf91: bound modem version parsing

Browse source 
Limit modem version tokens parsed from AT command responses to the LTE version field sizes. Also require both HWVERSION fields before copying them so a partial parse does not read an uninitialized temporary buffer.

Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
This commit is contained in:
Old-Ding 2026-07-06 07:34:56 +08:00 • committed by Xiang Xiao
parent 9888b7cd3b
commit a2b8d15041
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
arch/arm/src/nrf91/nrf91_modem_sock.c
View file

@ -451,20 +451,20 @@ static int nrf91_usrsock_event_callback(int16_t usockid, uint16_t events)
static int nrf91_modem_getver(lte_version_t *version)
{
char buffer1[16];
char buffer2[16];
char buffer1[LTE_VER_FIRMWARE_LEN];
char buffer2[LTE_VER_NP_PACKAGE_LEN];
int ret = OK;
memset(version, 0, sizeof(*version));
ret = nrf_modem_at_scanf("AT%HWVERSION", "%%HWVERSION: %s %s",
ret = nrf_modem_at_scanf("AT%HWVERSION", "%%HWVERSION: %31s %31s",
buffer1, buffer2);
if (ret > 0)
if (ret == 2)
{
strncpy(version->bb_product, buffer1, LTE_VER_BB_PRODUCT_LEN);
strncpy(version->np_package, buffer2, LTE_VER_NP_PACKAGE_LEN);
}
ret = nrf_modem_at_scanf("AT+CGMR", "%s", buffer1);
ret = nrf_modem_at_scanf("AT+CGMR", "%31s", buffer1);
if (ret > 0)
{
strncpy(version->fw_version, buffer1, LTE_VER_FIRMWARE_LEN);