arch/init: call up_color_intstack before up_irq_enable

Make sure interrupt stack is colored before IRQ is enabled.

Currently, after calling irq_initialize in nx_start to
enable interrupts, there is still a period of execution
path before the interrupt stack is colored.

Signed-off-by: guoshengyuan1 <guoshengyuan1@xiaomi.com>

arch/arm/src/a1x/a1x_irq.c

@@ -151,6 +151,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 

arch/arm/src/am335x/am335x_irq.c

@@ -125,6 +125,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/armv8-r/arm_doirq.c

@@ -127,6 +127,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/at32/at32_irq.c

@@ -364,6 +364,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/c5471/c5471_irq.c

@@ -158,6 +158,7 @@ void up_irqinitialize(void)
   /* And finally, enable interrupts */
 
 #ifndef CONFIG_SUPPRESS_INTERRUPTS
+  arm_color_intstack();
   up_irq_restore(PSR_MODE_SYS | PSR_F_BIT);
 #endif
 }

arch/arm/src/common/arm_checkstack.c

@@ -49,6 +49,31 @@
  * Public Functions
  ****************************************************************************/
 
+/****************************************************************************
+ * Name: arm_color_intstack
+ *
+ * Description:
+ *   Set the interrupt stack to a value so that later we can determine how
+ *   much stack space was used by interrupt handling logic
+ *
+ ****************************************************************************/
+
+#if defined(CONFIG_ARCH_INTERRUPTSTACK) && CONFIG_ARCH_INTERRUPTSTACK > 3
+void arm_color_intstack(void)
+{
+#ifdef CONFIG_SMP
+  int cpu;
+
+  for (cpu = 0; cpu < CONFIG_SMP_NCPUS; cpu++)
+    {
+      arm_stack_color((void *)up_get_intstackbase(cpu), INTSTACK_SIZE);
+    }
+#else
+  arm_stack_color((void *)g_intstackalloc, INTSTACK_SIZE);
+#endif
+}
+#endif
+
 /****************************************************************************
  * Name: arm_stack_check
  *

arch/arm/src/common/arm_initialize.c

@@ -38,37 +38,6 @@
 
 volatile bool g_interrupt_context[CONFIG_SMP_NCPUS];
 
-/****************************************************************************
- * Private Functions
- ****************************************************************************/
-
-/****************************************************************************
- * Name: arm_color_intstack
- *
- * Description:
- *   Set the interrupt stack to a value so that later we can determine how
- *   much stack space was used by interrupt handling logic
- *
- ****************************************************************************/
-
-#if defined(CONFIG_STACK_COLORATION) && CONFIG_ARCH_INTERRUPTSTACK > 3
-static inline void arm_color_intstack(void)
-{
-#ifdef CONFIG_SMP
-  int cpu;
-
-  for (cpu = 0; cpu < CONFIG_SMP_NCPUS; cpu++)
-    {
-      arm_stack_color((void *)up_get_intstackbase(cpu), INTSTACK_SIZE);
-    }
-#else
-  arm_stack_color((void *)g_intstackalloc, INTSTACK_SIZE);
-#endif
-}
-#else
-#  define arm_color_intstack()
-#endif
-
 /****************************************************************************
  * Public Functions
  ****************************************************************************/
@@ -98,10 +67,6 @@ void up_initialize(void)
   arm_initialize_stack();
 #endif
 
-  /* Colorize the interrupt stack */
-
-  arm_color_intstack();
-
   /* Add any extra memory fragments to the memory manager */
 
   arm_addregion();

arch/arm/src/common/arm_internal.h

@@ -479,6 +479,13 @@ size_t arm_stack_check(void *stackbase, size_t nbytes);
 void arm_stack_color(void *stackbase, size_t nbytes);
 #endif
 
+#if defined(CONFIG_STACK_COLORATION) &&\
+    defined(CONFIG_ARCH_INTERRUPTSTACK) && CONFIG_ARCH_INTERRUPTSTACK > 3
+void arm_color_intstack(void);
+#else
+#  define arm_color_intstack()
+#endif
+
 #ifdef CONFIG_ARCH_TRUSTZONE_SECURE
 int arm_gen_nonsecurefault(int irq, uint32_t *regs);
 #else

arch/arm/src/csk6/csk6_irq.c

@@ -208,6 +208,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/cxd32xx/cxd32_irq.c

@@ -317,6 +317,7 @@ void up_irqinitialize(void)
   /* And finally, enable interrupts */
 
 #ifndef CONFIG_SUPPRESS_INTERRUPTS
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/cxd56xx/cxd56_irq.c

@@ -368,6 +368,7 @@ void up_irqinitialize(void)
   /* And finally, enable interrupts */
 
 #ifndef CONFIG_SUPPRESS_INTERRUPTS
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/dm320/dm320_irq.c

@@ -91,6 +91,7 @@ void up_irqinitialize(void)
   /* And finally, enable interrupts */
 
 #ifndef CONFIG_SUPPRESS_INTERRUPTS
+  arm_color_intstack();
   up_irq_restore(PSR_MODE_SYS | PSR_F_BIT);
 #endif
 }

arch/arm/src/efm32/efm32_irq.c

@@ -366,6 +366,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/eoss3/eoss3_irq.c

@@ -347,6 +347,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/gd32f4/gd32f4xx_irq.c

@@ -371,6 +371,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/goldfish/goldfish_irq.c

@@ -124,6 +124,7 @@ void up_irqinitialize(void)
 #ifndef CONFIG_SUPPRESS_INTERRUPTS
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/imx1/imx_irq.c

@@ -63,6 +63,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_restore(PSR_MODE_SYS | PSR_F_BIT);
 #endif
 }

arch/arm/src/imx6/imx_irq.c

@@ -149,6 +149,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/imxrt/imxrt_irq.c

@@ -510,6 +510,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/kinetis/kinetis_irq.c

@@ -398,6 +398,7 @@ void up_irqinitialize(void)
   /* And finally, enable interrupts */
 
 #ifndef CONFIG_SUPPRESS_INTERRUPTS
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/kl/kl_irq.c

@@ -222,6 +222,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/lc823450/lc823450_irq.c

@@ -525,6 +525,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/lpc17xx_40xx/lpc17_40_irq.c

@@ -371,6 +371,7 @@ void up_irqinitialize(void)
   /* And finally, enable interrupts */
 
 #ifndef CONFIG_SUPPRESS_INTERRUPTS
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/lpc214x/lpc214x_irq.c

@@ -74,6 +74,7 @@ void up_irqinitialize(void)
   /* And finally, enable interrupts */
 
 #ifndef CONFIG_SUPPRESS_INTERRUPTS
+  arm_color_intstack();
   up_irq_restore(PSR_MODE_SYS | PSR_F_BIT);
 #endif
 }

arch/arm/src/lpc2378/lpc23xx_irq.c

@@ -87,6 +87,7 @@ void up_irqinitialize(void)
   /* Enable global ARM interrupts */
 
 #ifndef CONFIG_SUPPRESS_INTERRUPTS
+  arm_color_intstack();
   up_irq_restore(PSR_MODE_SYS | PSR_F_BIT);
 #endif
 }

arch/arm/src/lpc31xx/lpc31_irq.c

@@ -87,6 +87,7 @@ void up_irqinitialize(void)
 #ifndef CONFIG_SUPPRESS_INTERRUPTS
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_restore(PSR_MODE_SYS | PSR_F_BIT);
 #endif
 }

arch/arm/src/lpc43xx/lpc43_irq.c

@@ -351,6 +351,7 @@ void up_irqinitialize(void)
   /* And finally, enable interrupts */
 
 #ifndef CONFIG_SUPPRESS_INTERRUPTS
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/lpc54xx/lpc54_irq.c

@@ -356,6 +356,7 @@ void up_irqinitialize(void)
 #ifndef CONFIG_SUPPRESS_INTERRUPTS
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/max326xx/common/max326_irq.c

@@ -356,6 +356,7 @@ void up_irqinitialize(void)
 #ifndef CONFIG_SUPPRESS_INTERRUPTS
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/moxart/moxart_irq.c

@@ -116,6 +116,7 @@ void up_irqinitialize(void)
           getreg32(0x98800020));
 
 #ifndef CONFIG_SUPPRESS_INTERRUPTS
+  arm_color_intstack();
   up_irq_restore(PSR_MODE_SYS | PSR_F_BIT);
 #endif
 }

arch/arm/src/mps/mps_irq.c

@@ -251,6 +251,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/mx8mp/mx8mp_irq.c

@@ -416,6 +416,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/nrf52/nrf52_irq.c

@@ -362,6 +362,7 @@ void up_irqinitialize(void)
 #ifndef CONFIG_SUPPRESS_INTERRUPTS
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/nrf53/nrf53_irq.c

@@ -360,6 +360,7 @@ void up_irqinitialize(void)
 #ifndef CONFIG_SUPPRESS_INTERRUPTS
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/nrf91/nrf91_irq.c

@@ -368,6 +368,7 @@ void up_irqinitialize(void)
 #ifndef CONFIG_SUPPRESS_INTERRUPTS
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/nuc1xx/nuc_irq.c

@@ -214,6 +214,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/phy62xx/irq.c

@@ -345,6 +345,7 @@ void up_irqinitialize(void)
 
   /* svc(SVC_CALL_WR); */
 
+  arm_color_intstack();
   up_irq_enable();
 
 #endif

arch/arm/src/qemu/qemu_irq.c

@@ -130,6 +130,7 @@ void up_irqinitialize(void)
 #ifndef CONFIG_SUPPRESS_INTERRUPTS
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/rp2040/rp2040_irq.c

@@ -261,6 +261,7 @@ void up_irqinitialize(void)
   /* And finally, enable interrupts */
 
 #ifndef CONFIG_SUPPRESS_INTERRUPTS
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/rtl8720c/ameba_nvic.c

@@ -369,6 +369,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 }
 

arch/arm/src/s32k1xx/s32k11x/s32k11x_irq.c

@@ -177,6 +177,7 @@ void up_irqinitialize(void)
 #ifndef CONFIG_SUPPRESS_INTERRUPTS
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/s32k1xx/s32k14x/s32k14x_irq.c

@@ -391,6 +391,7 @@ void up_irqinitialize(void)
 #ifndef CONFIG_SUPPRESS_INTERRUPTS
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/s32k3xx/s32k3xx_irq.c

@@ -396,6 +396,7 @@ void up_irqinitialize(void)
 #ifndef CONFIG_SUPPRESS_INTERRUPTS
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/sam34/sam_irq.c

@@ -420,6 +420,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/sama5/sam_irq.c

@@ -536,6 +536,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/samd2l2/sam_irq.c

@@ -170,6 +170,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/samd5e5/sam_irq.c

@@ -505,6 +505,7 @@ void up_irqinitialize(void)
 #ifndef CONFIG_SUPPRESS_INTERRUPTS
   /* And finally, enable global interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/samv7/sam_irq.c

@@ -429,6 +429,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/stm32/stm32_irq.c

@@ -365,6 +365,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/stm32f0l0g0/stm32_irq.c

@@ -223,6 +223,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/stm32f7/stm32_irq.c

@@ -464,6 +464,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/stm32h5/stm32_irq.c

@@ -337,6 +337,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/stm32h7/stm32_irq.c

@@ -486,6 +486,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/stm32l4/stm32l4_irq.c

@@ -352,6 +352,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/stm32l5/stm32l5_irq.c

@@ -337,6 +337,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/stm32u5/stm32_irq.c

@@ -337,6 +337,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/stm32wb/stm32wb_irq.c

@@ -355,6 +355,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/stm32wl5/stm32wl5_irq.c

@@ -350,6 +350,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/str71x/str71x_irq.c

@@ -74,6 +74,7 @@ void up_irqinitialize(void)
   /* Enable global ARM interrupts */
 
 #ifndef CONFIG_SUPPRESS_INTERRUPTS
+  arm_color_intstack();
   up_irq_restore(PSR_MODE_SYS | PSR_F_BIT);
 #endif
 }

arch/arm/src/tiva/common/tiva_irq.c

@@ -480,6 +480,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/tlsr82/tlsr82_irq.c

@@ -49,6 +49,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  arm_color_intstack();
   up_irq_enable();
 }
 

arch/arm/src/tms570/tms570_irq.c

@@ -157,6 +157,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts globally */
 
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm/src/xmc4/xmc4_irq.c

@@ -401,6 +401,7 @@ void up_irqinitialize(void)
   /* And finally, enable interrupts */
 
 #ifndef CONFIG_SUPPRESS_INTERRUPTS
+  arm_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm64/src/common/arm64_doirq.c

@@ -44,6 +44,37 @@
 #include "arm64_gic.h"
 #include "arm64_fatal.h"
 
+/****************************************************************************
+ * Private Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: arm64_color_intstack
+ *
+ * Description:
+ *   Set the interrupt stack to a value so that later we can determine how
+ *   much stack space was used by interrupt handling logic
+ *
+ ****************************************************************************/
+
+#if defined(CONFIG_STACK_COLORATION) && CONFIG_ARCH_INTERRUPTSTACK > 3
+static inline void arm64_color_intstack(void)
+{
+#ifdef CONFIG_SMP
+  int cpu;
+
+  for (cpu = 0; cpu < CONFIG_SMP_NCPUS; cpu++)
+    {
+      arm64_stack_color((void *)up_get_intstackbase(cpu), INTSTACK_SIZE);
+    }
+#else
+  arm64_stack_color((void *)g_interrupt_stack, INTSTACK_SIZE);
+#endif
+}
+#else
+#  define arm64_color_intstack()
+#endif
+
 /****************************************************************************
  * Public Functions
  ****************************************************************************/
@@ -149,6 +180,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  arm64_color_intstack();
   up_irq_enable();
 #endif
 }

arch/arm64/src/common/arm64_initialize.c

@@ -99,33 +99,6 @@ uintptr_t up_get_intstackbase(int cpu)
 }
 #endif
 
-/****************************************************************************
- * Name: up_color_intstack
- *
- * Description:
- *   Set the interrupt stack to a value so that later we can determine how
- *   much stack space was used by interrupt handling logic
- *
- ****************************************************************************/
-
-#if defined(CONFIG_STACK_COLORATION) && CONFIG_ARCH_INTERRUPTSTACK > 3
-static void up_color_intstack(void)
-{
-#ifdef CONFIG_SMP
-  int cpu;
-
-  for (cpu = 0; cpu < CONFIG_SMP_NCPUS; cpu++)
-    {
-      arm64_stack_color((void *)up_get_intstackbase(cpu), INTSTACK_SIZE);
-    }
-#else
-  arm64_stack_color((void *)g_interrupt_stack, INTSTACK_SIZE);
-#endif
-}
-#else
-#  define up_color_intstack()
-#endif
-
 /****************************************************************************
  * Name: arm64_panic_disable_fpu
  *
@@ -162,10 +135,6 @@ int arm64_panic_disable_fpu(struct notifier_block *block,
 
 void up_initialize(void)
 {
-  /* Initialize global variables */
-
-  up_color_intstack();
-
   /* Add any extra memory fragments to the memory manager */
 
   arm64_addregion();

arch/avr/src/at32uc3/at32uc3_irq.c

@@ -221,6 +221,7 @@ void up_irqinitialize(void)
   /* And finally, enable interrupts */
 
 #ifndef CONFIG_SUPPRESS_INTERRUPTS
+  avr_color_intstack();
   up_irq_restore(0);
 #endif
 }

arch/avr/src/avr/avr_checkstack.c

@@ -51,6 +51,30 @@
  * Public Functions
  ****************************************************************************/
 
+/****************************************************************************
+ * Name: avr_color_intstack
+ *
+ * Description:
+ *   Set the interrupt stack to a value so that later we can determine how
+ *   much stack space was used by interrupt handling logic
+ *
+ ****************************************************************************/
+
+#if defined(CONFIG_ARCH_INTERRUPTSTACK) && CONFIG_ARCH_INTERRUPTSTACK > 3
+void avr_color_intstack(void)
+{
+  uint8_t *ptr = g_intstackalloc;
+  ssize_t size;
+
+  for (size = (CONFIG_ARCH_INTERRUPTSTACK & ~3);
+       size > 0;
+       size -= sizeof(uint8_t))
+    {
+      *ptr++ = STACK_COLOR;
+    }
+}
+#endif
+
 /****************************************************************************
  * Name: avr_stack_check
  *

arch/avr/src/common/avr_initialize.c

@@ -86,36 +86,6 @@ volatile uint32_t *g_current_regs;
 volatile uint8_t *g_current_regs;
 #endif
 
-/****************************************************************************
- * Private Functions
- ****************************************************************************/
-
-/****************************************************************************
- * Name: up_color_intstack
- *
- * Description:
- *   Set the interrupt stack to a value so that later we can determine how
- *   much stack space was used by interrupt handling logic
- *
- ****************************************************************************/
-
-#if defined(CONFIG_STACK_COLORATION) && CONFIG_ARCH_INTERRUPTSTACK > 3
-static inline void up_color_intstack(void)
-{
-  uint8_t *ptr = g_intstackalloc;
-  ssize_t size;
-
-  for (size = (CONFIG_ARCH_INTERRUPTSTACK & ~3);
-       size > 0;
-       size -= sizeof(uint8_t))
-    {
-      *ptr++ = INTSTACK_COLOR;
-    }
-}
-#else
-#  define up_color_intstack()
-#endif
-
 /****************************************************************************
  * Public Functions
  ****************************************************************************/
@@ -139,10 +109,6 @@ static inline void up_color_intstack(void)
 
 void up_initialize(void)
 {
-  /* Colorize the interrupt stack */
-
-  up_color_intstack();
-
   /* Add any extra memory fragments to the memory manager */
 
   avr_addregion();

arch/avr/src/common/avr_internal.h

@@ -176,5 +176,12 @@ void avr_usbuninitialize(void);
 size_t avr_stack_check(uintptr_t alloc, size_t size);
 #endif
 
+#if defined(CONFIG_STACK_COLORATION) && \
+    defined(CONFIG_ARCH_INTERRUPTSTACK) && CONFIG_ARCH_INTERRUPTSTACK > 3
+void avr_color_intstack(void);
+#else
+#  define avr_color_intstack()
+#endif
+
 #endif /* __ASSEMBLY__ */
 #endif /* __ARCH_AVR_SRC_COMMON_UP_INTERNAL_H */

arch/ceva/src/common/ceva_checkstack.c

@@ -44,6 +44,30 @@
  * Public Functions
  ****************************************************************************/
 
+/****************************************************************************
+ * Name: ceva_color_intstack
+ *
+ * Description:
+ *   Set the interrupt stack to a value so that later we can determine how
+ *   much stack space was used by interrupt handling logic
+ *
+ ****************************************************************************/
+
+#if defined(CONFIG_ARCH_INTERRUPTSTACK) && CONFIG_ARCH_INTERRUPTSTACK > 3
+void ceva_color_intstack(void)
+{
+  uint32_t *ptr = (uint32_t *)g_intstackalloc;
+  ssize_t size;
+
+  for (size = g_intstackbase - g_intstackalloc;
+       size > 0;
+       size -= sizeof(uint32_t))
+    {
+      *ptr++ = STACK_COLOR;
+    }
+}
+#endif
+
 /****************************************************************************
  * Name: ceva_stack_check
  *

arch/ceva/src/common/ceva_initialize.c

@@ -28,32 +28,6 @@
 
 #include "ceva_internal.h"
 
-/****************************************************************************
- * Private Functions
- ****************************************************************************/
-
-/****************************************************************************
- * Name: up_color_intstack
- *
- * Description:
- *   Set the interrupt stack to a value so that later we can determine how
- *   much stack space was used by interrupt handling logic
- *
- ****************************************************************************/
-
-static inline void up_color_intstack(void)
-{
-  uint32_t *ptr = (uint32_t *)g_intstackalloc;
-  ssize_t size;
-
-  for (size = g_intstackbase - g_intstackalloc;
-       size > 0;
-       size -= sizeof(uint32_t))
-    {
-      *ptr++ = INTSTACK_COLOR;
-    }
-}
-
 /****************************************************************************
  * Public Functions
  ****************************************************************************/
@@ -77,10 +51,6 @@ static inline void up_color_intstack(void)
 
 void up_initialize(void)
 {
-  /* Colorize the interrupt stack */
-
-  up_color_intstack();
-
   /* Add any extra memory fragments to the memory manager */
 
   ceva_addregion();

arch/ceva/src/common/ceva_internal.h

@@ -307,6 +307,13 @@ size_t ceva_stack_check(uintptr_t alloc, size_t size);
 void ceva_stack_color(void *stackbase, size_t nbytes);
 #endif
 
+#if defined(CONFIG_STACK_COLORATION) && \
+    defined(CONFIG_ARCH_INTERRUPTSTACK) && CONFIG_ARCH_INTERRUPTSTACK > 3
+void ceva_color_intstack(void);
+#else
+#  define ceva_color_intstack()
+#endif
+
 #undef EXTERN
 #ifdef __cplusplus
 }

arch/ceva/src/xc5/xc5_intc.c

@@ -199,5 +199,6 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  ceva_color_intstack();
   up_irq_enable();
 }

arch/ceva/src/xm6/xm6_intc.c

@@ -215,5 +215,6 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  ceva_color_intstack();
   up_irq_enable();
 }

arch/or1k/src/common/or1k_checkstack.c

@@ -52,6 +52,30 @@
  * Public Functions
  ****************************************************************************/
 
+/****************************************************************************
+ * Name: or1k_color_intstack
+ *
+ * Description:
+ *   Set the interrupt stack to a value so that later we can determine how
+ *   much stack space was used by interrupt handling logic
+ *
+ ****************************************************************************/
+
+#if defined(CONFIG_ARCH_INTERRUPTSTACK) && CONFIG_ARCH_INTERRUPTSTACK > 3
+void or1k_color_intstack(void)
+{
+  uint32_t *ptr = (uint32_t *)g_intstackalloc;
+  ssize_t size;
+
+  for (size = (CONFIG_ARCH_INTERRUPTSTACK & ~3);
+       size > 0;
+       size -= sizeof(uint32_t))
+    {
+      *ptr++ = STACK_COLOR;
+    }
+}
+#endif
+
 /****************************************************************************
  * Name: or1k_stack_check
  *

arch/or1k/src/common/or1k_initialize.c

@@ -106,32 +106,6 @@ void up_enable_dcache(void)
 }
 #endif
 
-/****************************************************************************
- * Name: up_color_intstack
- *
- * Description:
- *   Set the interrupt stack to a value so that later we can determine how
- *   much stack space was used by interrupt handling logic
- *
- ****************************************************************************/
-
-#if defined(CONFIG_STACK_COLORATION) && CONFIG_ARCH_INTERRUPTSTACK > 3
-static inline void up_color_intstack(void)
-{
-  uint32_t *ptr = (uint32_t *)g_intstackalloc;
-  ssize_t size;
-
-  for (size = (CONFIG_ARCH_INTERRUPTSTACK & ~3);
-       size > 0;
-       size -= sizeof(uint32_t))
-    {
-      *ptr++ = INTSTACK_COLOR;
-    }
-}
-#else
-#  define up_color_intstack()
-#endif
-
 /****************************************************************************
  * Public Functions
  ****************************************************************************/
@@ -155,10 +129,6 @@ static inline void up_color_intstack(void)
 
 void up_initialize(void)
 {
-  /* Colorize the interrupt stack */
-
-  up_color_intstack();
-
   /* Add any extra memory fragments to the memory manager */
 
   or1k_addregion();

arch/or1k/src/common/or1k_internal.h

@@ -325,6 +325,13 @@ size_t or1k_stack_check(uintptr_t alloc, size_t size);
 void or1k_stack_color(void *stackbase, size_t nbytes);
 #endif
 
+#if defined(CONFIG_STACK_COLORATION) && \
+    defined(CONFIG_ARCH_INTERRUPTSTACK) && CONFIG_ARCH_INTERRUPTSTACK > 3
+void or1k_color_intstack(void);
+#else
+#  define or1k_color_intstack()
+#endif
+
 #undef EXTERN
 #ifdef __cplusplus
 }

arch/or1k/src/mor1kx/or1k_irq.c

@@ -53,6 +53,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  or1k_color_intstack();
   up_irq_enable();
 }
 

arch/risc-v/src/bl602/bl602_irq.c

@@ -92,6 +92,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  riscv_color_intstack();
   up_irq_enable();
 #endif
 }

arch/risc-v/src/bl808/bl808_irq.c

@@ -187,6 +187,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  riscv_color_intstack();
   up_irq_enable();
 #endif
 }

arch/risc-v/src/c906/c906_irq.c

@@ -93,6 +93,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  riscv_color_intstack();
   up_irq_enable();
 #endif
 }

arch/risc-v/src/common/espressif/esp_irq.c

@@ -374,6 +374,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  riscv_color_intstack();
   up_irq_enable();
 #endif
 }

arch/risc-v/src/common/riscv_checkstack.c

@@ -48,6 +48,30 @@
  * Public Functions
  ****************************************************************************/
 
+/****************************************************************************
+ * Name: riscv_color_intstack
+ *
+ * Description:
+ *   Set the interrupt stack to a value so that later we can determine how
+ *   much stack space was used by interrupt handling logic
+ *
+ ****************************************************************************/
+
+#if defined(CONFIG_ARCH_INTERRUPTSTACK) && CONFIG_ARCH_INTERRUPTSTACK > 15
+void riscv_color_intstack(void)
+{
+  uint32_t *ptr = (uint32_t *)g_intstackalloc;
+  ssize_t size;
+
+  for (size = (CONFIG_ARCH_INTERRUPTSTACK & ~15);
+       size > 0;
+       size -= sizeof(uint32_t))
+    {
+      *ptr++ = STACK_COLOR;
+    }
+}
+#endif
+
 /****************************************************************************
  * Name: riscv_stack_check
  *

arch/risc-v/src/common/riscv_initialize.c

@@ -38,36 +38,6 @@
 
 volatile bool g_interrupt_context[CONFIG_SMP_NCPUS];
 
-/****************************************************************************
- * Private Functions
- ****************************************************************************/
-
-/****************************************************************************
- * Name: up_color_intstack
- *
- * Description:
- *   Set the interrupt stack to a value so that later we can determine how
- *   much stack space was used by interrupt handling logic
- *
- ****************************************************************************/
-
-#if defined(CONFIG_STACK_COLORATION) && CONFIG_ARCH_INTERRUPTSTACK > 15
-static inline void up_color_intstack(void)
-{
-  uint32_t *ptr = (uint32_t *)g_intstackalloc;
-  ssize_t size;
-
-  for (size = (CONFIG_ARCH_INTERRUPTSTACK & ~15);
-       size > 0;
-       size -= sizeof(uint32_t))
-    {
-      *ptr++ = INTSTACK_COLOR;
-    }
-}
-#else
-#  define up_color_intstack()
-#endif
-
 /****************************************************************************
  * Public Functions
  ****************************************************************************/
@@ -91,10 +61,6 @@ static inline void up_color_intstack(void)
 
 void up_initialize(void)
 {
-  /* Colorize the interrupt stack */
-
-  up_color_intstack();
-
   /* Add any extra memory fragments to the memory manager */
 
   riscv_addregion();

arch/risc-v/src/common/riscv_internal.h

@@ -364,6 +364,13 @@ size_t riscv_stack_check(uintptr_t alloc, size_t size);
 void riscv_stack_color(void *stackbase, size_t nbytes);
 #endif
 
+#if defined(CONFIG_STACK_COLORATION) && \
+    defined(CONFIG_ARCH_INTERRUPTSTACK) && CONFIG_ARCH_INTERRUPTSTACK > 15
+void riscv_color_intstack(void);
+#else
+#  define riscv_color_intstack()
+#endif
+
 #ifdef CONFIG_SMP
 void riscv_cpu_boot(int cpu);
 int riscv_smp_call_handler(int irq, void *c, void *arg);

arch/risc-v/src/esp32c3-legacy/esp32c3_irq.c

@@ -245,6 +245,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  riscv_color_intstack();
   up_irq_enable();
 #endif
 }

arch/risc-v/src/fe310/fe310_irq.c

@@ -86,6 +86,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  riscv_color_intstack();
   up_irq_enable();
 #endif
 }

arch/risc-v/src/hpm6000/hpm_irq.c

@@ -90,6 +90,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  riscv_color_intstack();
   up_irq_enable();
 #endif
 }

arch/risc-v/src/hpm6750/hpm6750_irq.c

@@ -90,6 +90,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  riscv_color_intstack();
   up_irq_enable();
 #endif
 }

arch/risc-v/src/jh7110/jh7110_irq.c

@@ -93,6 +93,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  riscv_color_intstack();
   up_irq_enable();
 #endif
 }

arch/risc-v/src/k210/k210_irq.c

@@ -99,6 +99,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  riscv_color_intstack();
   up_irq_enable();
 #endif
 }

arch/risc-v/src/k230/k230_irq.c

@@ -105,6 +105,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  riscv_color_intstack();
   up_irq_enable();
 #endif
 }

arch/risc-v/src/litex/litex_irq.c

@@ -93,6 +93,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  riscv_color_intstack();
   up_irq_enable();
 #endif
 }

arch/risc-v/src/mpfs/mpfs_irq.c

@@ -88,6 +88,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  riscv_color_intstack();
   up_irq_enable();
 #endif
 }

arch/risc-v/src/qemu-rv/qemu_rv_irq.c

@@ -154,6 +154,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  riscv_color_intstack();
   up_irq_enable();
 #endif
 }

arch/risc-v/src/rv32m1/rv32m1_irq.c

@@ -118,6 +118,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  riscv_color_intstack();
   up_irq_enable();
 #endif
 }

arch/risc-v/src/sg2000/sg2000_irq.c

@@ -100,6 +100,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
+  riscv_color_intstack();
   up_irq_enable();
 #endif
 }

arch/sparc/src/bm3803/bm3803-irq.c

@@ -93,6 +93,7 @@ void up_irqinitialize(void)
    * register
    */
 
+  sparc_color_intstack();
   up_irq_enable();
 }
 

arch/sparc/src/bm3823/bm3823-irq.c

@@ -98,6 +98,7 @@ void up_irqinitialize(void)
    * register
    */
 
+  sparc_color_intstack();
   up_irq_enable();
 }
 

arch/sparc/src/common/sparc_checkstack.c

@@ -49,6 +49,27 @@
  * Public Functions
  ****************************************************************************/
 
+/****************************************************************************
+ * Name: sparc_color_intstack
+ *
+ * Description:
+ *   Set the interrupt stack to a value so that later we can determine how
+ *   much stack space was used by interrupt handling logic
+ *
+ ****************************************************************************/
+
+#if defined(CONFIG_ARCH_INTERRUPTSTACK) && CONFIG_ARCH_INTERRUPTSTACK > 7
+void sparc_color_intstack(void)
+{
+  int cpu;
+
+  for (cpu = 0; cpu < CONFIG_SMP_NCPUS; cpu++)
+    {
+      sparc_stack_color((void *)up_get_intstackbase(cpu), INTSTACK_SIZE);
+    }
+}
+#endif
+
 /****************************************************************************
  * Name: sparc_stack_check
  *