From 7632dfd6c76b88eb7b1c9daf72194f6efedb31d3 Mon Sep 17 00:00:00 2001 From: Gregory Nutt Date: Thu, 8 Dec 2016 07:52:02 -0600 Subject: [PATCH] Update some comments. --- sched/task/task_exithook.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/sched/task/task_exithook.c b/sched/task/task_exithook.c index cffae18e7d9..3f75ec7ca18 100644 --- a/sched/task/task_exithook.c +++ b/sched/task/task_exithook.c @@ -73,6 +73,9 @@ static inline void task_atexit(FAR struct tcb_s *tcb) /* Make sure that we have not already left the group. Only the final * exiting thread in the task group should trigger the atexit() * callbacks. + * + * REVISIT: This is a security problem In the PROTECTED and KERNEL builds: + * We must not call the registered function in supervisor mode! */ if (group && group->tg_nmembers == 1) @@ -133,6 +136,9 @@ static inline void task_onexit(FAR struct tcb_s *tcb, int status) /* Make sure that we have not already left the group. Only the final * exiting thread in the task group should trigger the atexit() * callbacks. + * + * REVISIT: This is a security problem In the PROTECTED and KERNEL builds: + * We must not call the registered function in supervisor mode! */ if (group && group->tg_nmembers == 1)