Aksal/nuttx
3
1
Fork 1
mirror of https://github.com/apache/nuttx.git synced 2026-08-01 20:28:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

drivers: pci: Fix EPF debug assertions

Browse source 
pci_epf_device_register() and pci_epf_unregister_driver() used || in DEBUGASSERT expressions that validate a pointer and a required field or callback. If the pointer is NULL, the right-hand side dereferences it; if the pointer is valid but the required member is NULL, the assertion passes.

Require both conditions in each assertion so the debug checks match the preconditions used later in the functions.

Generated-by: OpenAI Codex
Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
This commit is contained in:
Old-Ding 2026-07-06 05:32:43 +08:00 • committed by Xiang Xiao
parent acc06c38f0
commit 74c79bbc05
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
drivers/pci/pci_epf.c
View file

@ -298,7 +298,7 @@ int pci_epf_device_register(FAR struct pci_epf_device_s *epf)
FAR struct pci_epc_ctrl_s *epc;
int ret;
DEBUGASSERT(epf != NULL || epf->name != NULL);
DEBUGASSERT(epf != NULL && epf->name != NULL);
ret = nxmutex_lock(&g_pci_epf_lock);
if (ret < 0)
@ -499,7 +499,7 @@ int pci_epf_unregister_driver(FAR struct pci_epf_driver_s *drv)
FAR struct pci_epf_device_s *epf;
int ret;
DEBUGASSERT(drv != NULL || drv->remove != NULL);
DEBUGASSERT(drv != NULL && drv->remove != NULL);
ret = nxmutex_lock(&g_pci_epf_lock);
if (ret < 0)