From 6bff1f4df4ae3e4fc21d7d98afdbfdcc855a6ed2 Mon Sep 17 00:00:00 2001 From: Gregory Nutt Date: Mon, 16 Dec 2019 03:53:05 -0600 Subject: [PATCH] arch/arm/include/samd2l2/sam_adc.h: I was wrong... this header file does belong in the samd2l2 include directory. It contains IOCTL definitions that are needed by applications. Usage of a chip-specific header file is, however, not really a good portable design because it requires that the application know that it is running on a specific chip. But still, if we are going to do that, the include directory is where the header file belongs. My apologies for the bad judgement. --- arch/arm/{src/samd2l2/adc.h => include/samd2l2/sam_adc.h} | 8 ++++---- arch/arm/src/samd2l2/sam_adc.c | 5 +++-- 2 files changed, 7 insertions(+), 6 deletions(-) rename arch/arm/{src/samd2l2/adc.h => include/samd2l2/sam_adc.h} (94%) diff --git a/arch/arm/src/samd2l2/adc.h b/arch/arm/include/samd2l2/sam_adc.h similarity index 94% rename from arch/arm/src/samd2l2/adc.h rename to arch/arm/include/samd2l2/sam_adc.h index c7c7880ee87..ffc051919cb 100644 --- a/arch/arm/src/samd2l2/adc.h +++ b/arch/arm/include/samd2l2/sam_adc.h @@ -1,5 +1,5 @@ /************************************************************************************ - * arch/arm/src/samd2l2/adc.h + * arch/arm/src/samd2l2/sam_adc.h * * Copyright (C) 2019 Gregory Nutt. All rights reserved. * Author: Gregory Nutt @@ -33,8 +33,8 @@ * ************************************************************************************/ -#ifndef __ARCH_ARM_SRC_SAMD2L2_ADC_H -#define __ARCH_ARM_SRC_SAMD2L2_ADC_H +#ifndef __ARCH_ARM_SRC_SAMD2L2_SAM_ADC_H +#define __ARCH_ARM_SRC_SAMD2L2_SAM_ADC_H /**************************************************************************** * Pre-processor Definitions @@ -58,4 +58,4 @@ struct sam_adc_param_s uint8_t averaging; /* number of samples to be collected */ }; -#endif /* __ARCH_ARM_SRC_SAMD2L2_ADC_H */ +#endif /* __ARCH_ARM_SRC_SAMD2L2_SAM_ADC_H */ diff --git a/arch/arm/src/samd2l2/sam_adc.c b/arch/arm/src/samd2l2/sam_adc.c index 99ad3c0717a..bf626fd5c5a 100644 --- a/arch/arm/src/samd2l2/sam_adc.c +++ b/arch/arm/src/samd2l2/sam_adc.c @@ -57,10 +57,9 @@ #include #include -#include +#include #include "up_arch.h" -#include "adc.h" #include "sam_adc.h" #include "sam_pinmap.h" #include "sam_gclk.h" @@ -68,6 +67,8 @@ #include "sam_fuses.h" #include "samd_periphclks.h" +#include + /**************************************************************************** * Private Function Prototypes ****************************************************************************/