diff --git a/tools/checkpatch.sh b/tools/checkpatch.sh index 08adb2136b5..6c10fd43ae2 100755 --- a/tools/checkpatch.sh +++ b/tools/checkpatch.sh @@ -42,17 +42,13 @@ usage() { } check_file() { - $TOOLDIR/nxstyle $@ 2>&1 - ret=$? - if [ $ret != 0 ]; then - fail=$ret + if ! $TOOLDIR/nxstyle $@ 2>&1; then + fail=1 fi if [ $spell != 0 ]; then - codespell -q 7 ${@: -1} - ret=$? - if [ $ret != 0 ]; then - fail=$ret + if ! codespell -q 7 ${@: -1}; then + fail=1 fi fi } @@ -83,10 +79,8 @@ check_ranges() { } check_patch() { - git apply --check $1 - ret=$? - if [ $ret != 0 ]; then - fail=$ret + if ! git apply --check $1; then + fail=1 else git apply $1 diffs=`cat $1` diff --git a/tools/testbuild.sh b/tools/testbuild.sh index eca88ee7461..d1f3f34e8a4 100755 --- a/tools/testbuild.sh +++ b/tools/testbuild.sh @@ -158,10 +158,8 @@ blacklist=`grep "^-" $testfile || true` cd $nuttx || { echo "ERROR: failed to CD to $nuttx"; exit 1; } function makefunc { - ${MAKE} ${MAKE_FLAGS} "${EXTRA_FLAGS}" $@ 1>/dev/null - ret=$? - if [ $ret != 0 ]; then - fail=$ret + if ! ${MAKE} ${MAKE_FLAGS} "${EXTRA_FLAGS}" $@ 1>/dev/null; then + fail=1 fi }