Aksal/nuttx
3
1
Fork 1
mirror of https://github.com/apache/nuttx.git synced 2026-10-03 20:27:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

drivers/mmcsd/mmcsd_sdio.c: Fix setting SDIO_WIDEBUS for SD cards

Browse source 
This corrects the setting widebus for SD cards, which was recently broken in 4f7f751d2a.

The if checking the priv->caps, priv->buswidth and IS_MMC has been wrong for
some time. The proper logic is that for MMC only the priv->caps is checked.
For SD card, both priv->caps and priv->buswidth need to be checked.

Signed-off-by: Jukka Laitinen <jukkax@ssrc.tii.ae>
This commit is contained in:
Jukka Laitinen 2024-09-23 15:59:25 +03:00 • committed by Xiang Xiao
parent 5e74ed8d34
commit 5238c3bb25
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
drivers/mmcsd/mmcsd_sdio.c
View file

@ -2690,8 +2690,9 @@ static int mmcsd_widebus(FAR struct mmcsd_state_s *priv)
/* Configure the SDIO peripheral */
if ((IS_MMC(priv->type) && ((priv->caps & SDIO_CAPS_1BIT_ONLY) == 0)) &&
((priv->buswidth & MMCSD_SCR_BUSWIDTH_4BIT) != 0))
if ((priv->caps & SDIO_CAPS_1BIT_ONLY) == 0 &&
(IS_MMC(priv->type) ||
(priv->buswidth & MMCSD_SCR_BUSWIDTH_4BIT) != 0))
{
/* JEDEC specs: A.8.3 Changing the data bus width: 'Bus testing
* procedure' shows how mmc bus width may be detected. This driver