From 39ab0f48364e55adab4336385dce4e2d7ade4095 Mon Sep 17 00:00:00 2001 From: YAMAMOTO Takashi Date: Fri, 14 Jan 2022 14:15:09 +0900 Subject: [PATCH] Do not require write-access for fsync * fsync doesn't modify the file. It doesn't make sense to require write-access. * This matches what ~all other systems do. At least Linux, macOS, and NetBSD. --- fs/vfs/fs_fsync.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/fs/vfs/fs_fsync.c b/fs/vfs/fs_fsync.c index e49f6f63871..2eb4cc05ad9 100644 --- a/fs/vfs/fs_fsync.c +++ b/fs/vfs/fs_fsync.c @@ -55,13 +55,6 @@ int file_fsync(FAR struct file *filep) { struct inode *inode; - /* Was this file opened for write access? */ - - if ((filep->f_oflags & O_WROK) == 0) - { - return -EBADF; - } - /* Is this inode a registered mountpoint? Does it support the * sync operations may be relevant to device drivers but only * the mountpoint operations vtable contains a sync method.