Aksal/nuttx
3
1
Fork 1
mirror of https://github.com/apache/nuttx.git synced 2026-08-09 22:45:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

drivers/devfreq: fix qos_get_value returning wrong min/max aggregation

Browse source 
QOS_REQ_MIN should return the highest value among all min requests
(most restrictive lower bound), but plist_first returns the lowest.
QOS_REQ_MAX should return the lowest value among all max requests
(most restrictive upper bound), but plist_last returns the highest.

This caused qos constraints to be ineffective. For example, two
requests (32, 208000) and (104000, 104000) would merge to (32, 208000)
instead of the correct (104000, 104000).

Fix by using plist_last for QOS_REQ_MIN and plist_first for QOS_REQ_MAX.

Signed-off-by: guanyi3 <guanyi3@xiaomi.com>
This commit is contained in:
guanyi3 2026-03-06 16:26:00 +08:00 • committed by Alan C. Assis
parent 674e5ef4d8
commit 31041f84ea
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
drivers/devfreq/devfreq_qos.c
View file

@ -191,12 +191,12 @@ uint32_t qos_get_value(FAR struct qos_constraints_s *constraints,
{
case QOS_REQ_MIN:
{
return plist_first(&constraints->min_requests)->prio;
return plist_last(&constraints->min_requests)->prio;
}
case QOS_REQ_MAX:
{
return plist_last(&constraints->max_requests)->prio;
return plist_first(&constraints->max_requests)->prio;
}
}