Aksal/nuttx
3
1
Fork 1
mirror of https://github.com/apache/nuttx.git synced 2026-10-10 07:40:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

vfs: poll: fix resource leak and memory corruption. From Jussi Kivilinna.

Browse source
This commit is contained in:
Gregory Nutt 2015-05-04 09:09:09 -06:00
parent e903259476
commit 157ac4fb59
1 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

12
fs/vfs/fs_poll.c
View file

@ -162,6 +162,7 @@ static int poll_fdsetup(int fd, FAR struct pollfd *fds, bool setup)
static inline int poll_setup(FAR struct pollfd *fds, nfds_t nfds, sem_t *sem)
{
unsigned int i;
unsigned int j;
int ret;
/* Process each descriptor in the list */
@ -190,6 +191,17 @@ static inline int poll_setup(FAR struct pollfd *fds, nfds_t nfds, sem_t *sem)
ret = poll_fdsetup(fds[i].fd, &fds[i], true);
if (ret < 0)
{
/* Setup failed for fds[i]. We now need to teardown previously
* setup fds[0 .. (i - 1)] to release allocated resources and
* to prevent memory corruption by access to freed/released 'fds'
* and 'sem'.
*/
for (j = 0; j < i; j++)
{
(void)poll_fdsetup(fds[j].fd, &fds[j], false);
}
return ret;
}
}