Aksal/nuttx
3
1
Fork 1
mirror of https://github.com/apache/nuttx.git synced 2026-10-09 15:25:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Changes from review of 6f94e4e9e7

Browse source
This commit is contained in:
Gregory Nutt 2017-08-02 08:36:17 -06:00
parent 5f2d4b8f84
commit 0960b50f3f
11 changed files with 9 additions and 91 deletions
Download patch file Download diff file Expand all files Collapse all files

4
configs/lc823450-xgevk/README.txt
View file

@ -14,7 +14,6 @@ LC823450 related documents are available at
This port is intended to test LC823450 features including SMP.
Supported peripherals are UART, TIMER, RTC, GPIO, DMA, I2C, SPI, LCD.
Settings
^^^^^^^^
@ -25,7 +24,6 @@ Settings
5. Serial console can be used via external USB-UART (115200/8/N/1).
6. Interrupt handlers except for inter-cpu are handled on CPU0.
SMP related Status
^^^^^^^^^^^^^^^^^^
@ -36,7 +34,6 @@ output into the console because UART operates in FIFO mode.
1. "nsh> smp" works but the result will be corrupted.
2. "nsh> ostest" works but might cause a deadlock or assertion.
Other Status
^^^^^^^^^^^^
@ -76,7 +73,6 @@ nxhello_main: Screen resolution (128,48)
nxhello_hello: Position (31,20)
nxhello_main: Close NX
TODO
^^^^

5
configs/lc823450-xgevk/include/board.h
View file

@ -33,7 +33,6 @@
*
****************************************************************************/
#ifndef __CONFIGS_LC823450_XGEVK_INCLUDE_BOARD_H
#define __CONFIGS_LC823450_XGEVK_INCLUDE_BOARD_H
@ -46,7 +45,8 @@
#if defined(__cplusplus)
#define EXTERN extern "C"
extern "C" {
extern "C"
{
#else
#define EXTERN extern
#endif
@ -59,7 +59,6 @@ extern unsigned int XT1OSC_CLK;
void up_init_default_mux(void);
#undef EXTERN
#if defined(__cplusplus)
}

1
configs/lc823450-xgevk/scripts/ld.script
View file

@ -33,7 +33,6 @@
*
****************************************************************************/
MEMORY
{
progmem (rx) : ORIGIN = 0x02040000, LENGTH = 480K

12
configs/lc823450-xgevk/src/lc823450-xgevk.h
View file

@ -33,7 +33,6 @@
*
****************************************************************************/
#ifndef __CONFIGS_LC823450_XGEVK_SRC_LC823450_XGEVK_H
#define __CONFIGS_LC823450_XGEVK_SRC_LC823450_XGEVK_H
@ -57,15 +56,6 @@
# undef HAVE_I2CTOOL
#endif
/****************************************************************************
* Public Types
****************************************************************************/
/****************************************************************************
* Public data
****************************************************************************/
#ifndef __ASSEMBLY__
/****************************************************************************
@ -84,10 +74,10 @@
int lc823450_bringup(void);
#endif
/************************************************************************************
* Name: lc823450_bma250initialize
************************************************************************************/
#ifdef CONFIG_BMA250
int lc823450_bma250initialize(FAR const char *devpath);
#endif

21
configs/lc823450-xgevk/src/lc823450-xgevk_mux.h
View file

@ -37,10 +37,6 @@
#ifndef __CONFIGS_LC823450_XGEVK_SRC_LC823450_XGEVK_MUX_H
#define __CONFIGS_LC823450_XGEVK_SRC_LC823450_XGEVK_MUX_H
/****************************************************************************
* Included Files
****************************************************************************/
/****************************************************************************
* Pre-processor Definitions
****************************************************************************/
@ -234,7 +230,6 @@
0 << 14 | /* GPIO1E 0:0, 1:1 */ \
0 << 15 /* GPIO1F 0:0, 1:1 */ \
/****************************************************************************
* PORT2
****************************************************************************/
@ -329,7 +324,6 @@
0 << 14 | /* GPIO2E 0:0, 1:1 */ \
0 << 15 /* GPIO2F 0:0, 1:1 */ \
/****************************************************************************
* PORT3
****************************************************************************/
@ -424,7 +418,6 @@
0 << 14 | /* GPIO3E 0:0, 1:1 */ \
0 << 15 /* GPIO3F 0:0, 1:1 */
/****************************************************************************
* PORT4
****************************************************************************/
@ -519,7 +512,6 @@
0 << 14 | /* GPIO4E 0:0, 1:1 */ \
0 << 15 /* GPIO4F 0:0, 1:1 */
/****************************************************************************
* PORT5
****************************************************************************/
@ -613,17 +605,4 @@
0 << 22 | /* XTALI0 0:2mA, 1:---, 2:4mA, 3:8mA */ \
0 << 24 /* XTALI1 0:2mA, 1:---, 2:4mA, 3:8mA */
/****************************************************************************
* Public Types
****************************************************************************/
/****************************************************************************
* Public data
****************************************************************************/
/****************************************************************************
* Public Functions
****************************************************************************/
#endif /* __CONFIGS_LC823450_XGEVK_SRC_LC823450_XGEVK_MUX_H */

15
configs/lc823450-xgevk/src/lc823450_appinit.c
View file

@ -40,6 +40,7 @@
#include <nuttx/config.h>
#include <stdio.h>
#include <syslog.h>
#include <nuttx/board.h>
#include <nuttx/i2c/i2c_master.h>
@ -49,10 +50,6 @@
#ifdef CONFIG_LIB_BOARDCTL
/****************************************************************************
* Pre-processor Definitions
****************************************************************************/
/****************************************************************************
* Private Functions
****************************************************************************/
@ -74,14 +71,15 @@ static void lc823450_i2c_register(int bus)
i2c = lc823450_i2cbus_initialize(bus);
if (i2c == NULL)
{
_err("ERROR: Failed to get I2C%d interface\n", bus);
syslog(LOG_ERR, "ERROR: Failed to get I2C%d interface\n", bus);
}
else
{
ret = i2c_register(i2c, bus);
if (ret < 0)
{
_err("ERROR: Failed to register I2C%d driver: %d\n", bus, ret);
syslog(LOG_ERR, "ERROR: Failed to register I2C%d driver: %d\n",
bus, ret);
lc823450_i2cbus_uninitialize(i2c);
}
}
@ -114,7 +112,6 @@ static void lc823450_i2ctool(void)
* Public Functions
****************************************************************************/
/****************************************************************************
* Name: board_app_initialize
*
@ -152,7 +149,7 @@ int board_app_initialize(uintptr_t arg)
int ret = lc823450_mtd_initialize(CONFIG_MTD_DEVNO_EMMC);
if (ret != OK)
{
_err("Failed to initialize eMMC: ret=%d\n", ret);
syslog(LOG_ERR, "Failed to initialize eMMC: ret=%d\n", ret);
}
#ifdef CONFIG_LC823450_SDIF_SDC
@ -161,7 +158,7 @@ int board_app_initialize(uintptr_t arg)
ret = lc823450_mtd_initialize(CONFIG_MTD_DEVNO_SDC);
if (ret != OK)
{
_err("Failed to initialize uSD: ret=%d\n", ret);
syslog(LOG_ERR, "Failed to initialize uSD: ret=%d\n", ret);
}
#endif /* CONFIG_LC823450_SDIF_SDC */

11
configs/lc823450-xgevk/src/lc823450_boot.c
View file

@ -33,25 +33,14 @@
*
****************************************************************************/
/****************************************************************************
* Included Files
****************************************************************************/
#include <nuttx/config.h>
#include <debug.h>
#include <nuttx/board.h>
/****************************************************************************
* Pre-processor Definitions
****************************************************************************/
/****************************************************************************
* Private Functions
****************************************************************************/
/****************************************************************************
* Public Functions
****************************************************************************/

8
configs/lc823450-xgevk/src/lc823450_bringup.c
View file

@ -47,14 +47,6 @@
#include "lc823450-xgevk.h"
/****************************************************************************
* Pre-processor Definitions
****************************************************************************/
/****************************************************************************
* Private Functions
****************************************************************************/
/****************************************************************************
* Public Functions
****************************************************************************/

10
configs/lc823450-xgevk/src/lc823450_mux.c
View file

@ -52,15 +52,6 @@
#include "lc823450-xgevk_mux.h"
/****************************************************************************
* Pre-processor Definitions
****************************************************************************/
/****************************************************************************
* Private Functions
****************************************************************************/
/****************************************************************************
* Public Functions
****************************************************************************/
@ -129,5 +120,4 @@ void up_init_default_mux(void)
putreg32(PORT6_PUPD, PUDCNT6);
putreg32(PORT6_DRV, PTDRVCNT6);
}

6
configs/lc823450-xgevk/src/lc823450_spi.c
View file

@ -47,15 +47,10 @@
#include "lc823450_gpio.h"
/****************************************************************************
* Pre-processor Definitions
****************************************************************************/
/****************************************************************************
* Public Functions
****************************************************************************/
/****************************************************************************
* Name: lc823450_spiselect
*
@ -66,7 +61,6 @@ void lc823450_spiselect(FAR struct spi_dev_s *dev, uint32_t devid, bool selected
/* no need */
}
/****************************************************************************
* Name: lc823450_spiinitialize
*

7
configs/lc823450-xgevk/src/lc823450_st7565.c
View file

@ -37,7 +37,6 @@
* Included Files
****************************************************************************/
#include <nuttx/config.h>
#include <sys/types.h>
@ -57,7 +56,6 @@
#include "lc823450_spi.h"
#include "lc823450-xgevk.h"
#ifdef CONFIG_NX_LCDDRIVER
/****************************************************************************
@ -74,7 +72,6 @@
* Private Data
****************************************************************************/
static void lc823450_st7565_reset(FAR struct st7565_lcd_s *lcd, bool on);
static void lc823450_st7565_select(FAR struct st7565_lcd_s *lcd);
static void lc823450_st7565_deselect(FAR struct st7565_lcd_s *lcd);
@ -97,7 +94,6 @@ static struct st7565_lcd_s g_st7565_dev =
.backlight = lc823450_st7565_backlight,
};
/****************************************************************************
* Private Functions
****************************************************************************/
@ -166,8 +162,6 @@ static int lc823450_st7565_backlight(FAR struct st7565_lcd_s *lcd, int level)
return 0;
}
/****************************************************************************
* Public Functions
****************************************************************************/
@ -188,7 +182,6 @@ int board_lcd_initialize(void)
return 0;
}
/****************************************************************************
* Name: board_lcd_getdev
****************************************************************************/