nuttx-apps/games/NXDoom/src/doom
Jorge Guzman 5a73a6f124 games/NXDoom: drop the assignments left over from dehacked
Six statements assign a variable to itself, which clang rejects:

  src/doom/f_finale.c:637:16: error: explicitly assigning value of
  variable of type 'const char *' to itself [-Werror,-Wself-assign]
    637 |       lumpname = (lumpname);

Chocolate DOOM wraps those strings in DEH_String() so that a dehacked
patch can substitute them. The port has no dehacked support, and the
macro went away with it, leaving the parentheses behind. Two comments
that only described the substitution go as well.

Nothing changes at run time. GCC does not warn about this, so the
configurations built so far never noticed; the ones built with clang
do, and they fail because the CI treats warnings as errors.

Signed-off-by: Jorge Guzman <jorge.gzm@gmail.com>
2026-08-04 12:48:54 +08:00
..
.gitignore apps/games/NXDoom: Original Chocolate DOOM source 2026-06-30 15:22:55 -03:00
am_map.c games/NXDoom: Fix build warnings 2026-07-02 09:08:46 -03:00
am_map.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
d_englsh.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
d_french.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
d_items.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
d_items.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
d_main.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
d_main.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
d_net.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
d_player.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
d_textur.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
d_think.h games/NXDoom: Fix build warnings 2026-07-02 09:08:46 -03:00
deh_ammo.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
deh_bexstr.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
deh_cheat.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
deh_doom.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
deh_frame.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
deh_misc.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
deh_misc.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
deh_ptr.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
deh_sound.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
deh_thing.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
deh_weapon.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
doomdata.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
doomdef.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
doomdef.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
doomstat.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
doomstat.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
dstrings.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
dstrings.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
f_finale.c games/NXDoom: drop the assignments left over from dehacked 2026-08-04 12:48:54 +08:00
f_finale.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
f_wipe.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
f_wipe.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
g_game.c games/NXDoom: drop the assignments left over from dehacked 2026-08-04 12:48:54 +08:00
g_game.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
hu_lib.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
hu_lib.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
hu_stuff.c games/NXDoom: drop the assignments left over from dehacked 2026-08-04 12:48:54 +08:00
hu_stuff.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
info.c games/NXDoom: Fix build warnings 2026-07-02 09:08:46 -03:00
info.h games/NXDoom: Fix build warnings 2026-07-02 09:08:46 -03:00
m_menu.c games/NXDoom: Fix build warnings 2026-07-02 09:08:46 -03:00
m_menu.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
m_random.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
m_random.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
p_ceilng.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
p_doors.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
p_enemy.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
p_floor.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
p_inter.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
p_inter.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
p_lights.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
p_local.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
p_map.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
p_maputl.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
p_mobj.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
p_mobj.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
p_plats.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
p_pspr.c games/NXDoom: Fix build warnings 2026-07-02 09:08:46 -03:00
p_pspr.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
p_saveg.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
p_saveg.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
p_setup.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
p_setup.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
p_sight.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
p_spec.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
p_spec.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
p_switch.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
p_telept.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
p_tick.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
p_tick.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
p_user.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
r_bsp.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
r_bsp.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
r_data.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
r_data.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
r_defs.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
r_draw.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
r_draw.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
r_local.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
r_main.c games/NXDoom: Fix build warnings 2026-07-02 09:08:46 -03:00
r_main.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
r_plane.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
r_plane.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
r_segs.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
r_segs.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
r_sky.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
r_sky.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
r_state.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
r_things.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
r_things.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
s_sound.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
s_sound.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
sounds.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
sounds.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
st_lib.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
st_lib.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
st_stuff.c games/NXDoom: Fix build warnings 2026-07-02 09:08:46 -03:00
st_stuff.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
statdump.c games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
statdump.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00
wi_stuff.c games/NXDoom: Fix build warnings 2026-07-02 09:08:46 -03:00
wi_stuff.h games/NXDoom: Initial port of Chocolate DOOM to NuttX. 2026-06-30 15:22:55 -03:00