nuttx-apps/netutils
Marco Casaroli 860815a33a testing/ostest: Split the fork test into vfork and fork.
ostest's "vfork" test was never testing vfork().  It has the child write a
global and the parent observe the write -- the defining property of *sharing*,
not of vfork(), whose defining property is that the parent is suspended and
whose contract forbids the child to write anything at all.  It passed because
NuttX implemented fork() and vfork() as the same sharing primitive, which
apache/nuttx#19562 separates.

vfork.c is rewritten to test what vfork() promises.  The child does only what
POSIX permits -- it calls _exit(42) and nothing else, not even exit(), which
would run atexit handlers and flush stdio in the parent's address space.  Since
the child may not write memory and the parent cannot run while the child lives,
the observable is the child's exit status:  had the parent not been suspended,
it would have reached waitpid() while the child was still alive.  Where child
status is not retained -- ostest_main() sets SA_NOCLDWAIT for the whole run,
deliberately -- ECHILD is accepted as equally good evidence, since it says the
child was already gone when the parent asked.

fork.c is new and tests POSIX fork():  the child's writes to .data, .bss and
the heap are invisible to the parent and vice versa, a pointer to a stack local
taken before the fork names the same object in both, and the child does
everything a vfork() child may not -- calls malloc() and printf(), and returns
from the function that called fork().

Both run at the top of user_main().  They exercise the lowest-level machinery
in the suite -- address environments, stack setup, the architecture's register
context -- so a fault in one takes the process down instead of reporting a
failure.  Learning that in seconds rather than after everything else has passed
matters when a port is being brought up.

Each test gates on the one primitive it tests, ARCH_HAVE_VFORK and
ARCH_HAVE_FORK respectively.  There is no compatibility layer and no mapping
between symbols.  vfork.c no longer requires SCHED_WAITPID:  the suspension is
in the kernel primitive now, so the test's core assertion holds without it and
only the status check is conditional.

The simulator is the one exception.  It selects ARCH_HAVE_VFORK, but ostest
takes the sim down as soon as the test runs there, so the call keeps the
!ARCH_SIM guard that apps ee7642793 put on the old test in 2024.  The old gate
hid this:  ARCH_HAVE_FORK is not set on the sim, so the test was not built
there at all.

The other in-tree callers are audited for which primitive they actually meant:

* interpreters/python's _posixsubprocess and netutils/libwebsockets'
  LWS_HAVE_WORKING_VFORK want the fork-then-exec path -- ARCH_HAVE_VFORK.
* python's os.fork() and libwebsockets' LWS_HAVE_FORK mean real fork() and stay
  on ARCH_HAVE_FORK, so they become *absent* rather than silently wrong.
* testing/fs/fdsantest's vfork case follows ARCH_HAVE_VFORK.

interpreters/bas is deliberately left alone.  Its SHELL and EDIT statements
reach for vfork() under an ARCH_HAVE_FORK guard and want the same treatment,
but checkpatch.sh checks the whole of any file a patch touches and
bas_statement.c produces 1681 pre-existing findings against master, so a
one-line change there fails CI on its own.  The consequence is small:
EXAMPLES_BAS_SHELL is EXPERIMENTAL and already depends on ARCH_HAVE_FORK, so it
becomes unselectable rather than misbehaving.

Assisted-by: Claude Code:claude-opus-5
Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
2026-08-14 07:46:54 -03:00
..
bare netutils: Add BARE 2026-01-23 11:05:48 -03:00
chat apps: Fix unchecked strdup()/asprintf() as requested in #1727 2026-05-23 16:30:52 -04:00
cjson netutils/cjson: fix apps path in CMake 2026-03-26 20:18:52 -04:00
cmux include/debug.h: Use <nuttx/debug.h> in apps 2026-04-11 10:39:27 -03:00
codecs !fsutils/passwd: Replace TEA with PBKDF2-HMAC-SHA256 2026-07-22 17:21:22 +08:00
connectedhomeip cmake: Use NUTTX(_DIR/_BINARY_DIR) instead of CMAKE(_SOURCE_DIR/BINARY_DIR) 2026-08-09 10:43:01 -03:00
cwebsocket netutils: migrate the license to ASF 2024-12-21 13:53:10 +08:00
dhcp6c include/debug.h: Use <nuttx/debug.h> in apps 2026-04-11 10:39:27 -03:00
dhcpc netutils/dhcpc: parse DHCP NTP server option 2026-04-24 10:44:08 -03:00
dhcpd !apps: replace sclock_t with clock_t and drop redundant time_t/off_t casts 2026-05-11 17:38:32 +08:00
discover include/debug.h: Use <nuttx/debug.h> in apps 2026-04-11 10:39:27 -03:00
dropbear netutils/dropbear, testing/nand_sim: do not use fork() to run in background. 2026-08-03 09:22:39 -03:00
esp8266 include/debug.h: Use <nuttx/debug.h> in apps 2026-04-11 10:39:27 -03:00
ftpc apps: Fix unchecked strdup()/asprintf() as requested in #1727 2026-05-23 16:30:52 -04:00
ftpd apps: Fix unchecked strdup()/asprintf() as requested in #1727 2026-05-23 16:30:52 -04:00
iperf iperf: compatible work with no IPv4 2026-01-04 00:06:17 +08:00
iptables netutils: migrate the license to ASF 2024-12-21 13:53:10 +08:00
jsoncpp cmake: Use NUTTX(_DIR/_BINARY_DIR) instead of CMAKE(_SOURCE_DIR/BINARY_DIR) 2026-08-09 10:43:01 -03:00
libcoap cmake: Use NUTTX(_DIR/_BINARY_DIR) instead of CMAKE(_SOURCE_DIR/BINARY_DIR) 2026-08-09 10:43:01 -03:00
libcurl4nx include/debug.h: Use <nuttx/debug.h> in apps 2026-04-11 10:39:27 -03:00
libshvc apps: fix distclean for partial builds and residual .kconfig files 2026-07-09 09:25:33 +08:00
libulut apps: fix distclean for partial builds and residual .kconfig files 2026-07-09 09:25:33 +08:00
libwebsockets testing/ostest: Split the fork test into vfork and fork. 2026-08-14 07:46:54 -03:00
mdns netutils/mdns: raise responder stack size default to 8KiB 2026-07-31 15:19:31 +08:00
mqttc netutils/mqttc: fix patch and add mbedtls dependency 2026-04-10 12:23:37 -03:00
nanopb netutils/nanopb: fix unpack step for MACOS 2025-07-14 15:48:08 -03:00
netcat netutils: migrate the license to ASF 2024-12-21 13:53:10 +08:00
netinit !apps: drop CONFIG_SYSTEM_TIME64 conditionals 2026-05-11 17:38:32 +08:00
netlib netlib: replace DNS ping with gateway ping for connectivity check 2026-05-14 11:58:15 +08:00
nng cmake: Use NUTTX(_DIR/_BINARY_DIR) instead of CMAKE(_SOURCE_DIR/BINARY_DIR) 2026-08-09 10:43:01 -03:00
ntpclient !apps: drop redundant casts on tv_sec/tv_nsec and fix printf formats 2026-05-22 13:38:25 +08:00
paho_mqtt netutils/paho_mqtt: fixed the header file 2026-08-11 15:38:46 -04:00
ping icmpv6_ping.c: change socket type from SOCK_DGRAM to SOCK_RAW. 2026-01-19 22:52:06 +08:00
plcatool netutils: Add plcatool 2025-09-17 19:29:10 +08:00
pppd include/debug.h: Use <nuttx/debug.h> in apps 2026-04-11 10:39:27 -03:00
ptpd !apps: drop redundant casts on tv_sec/tv_nsec and fix printf formats 2026-05-22 13:38:25 +08:00
rexec netutils/rexec: initialize ret to avoid maybe-uninitialized 2026-06-27 08:47:46 -03:00
rexecd netutils/rexecd: forward PRIORITY/STACKSIZE config in CMake build 2026-07-23 17:18:08 -03:00
rtptools cmake: Use NUTTX(_DIR/_BINARY_DIR) instead of CMAKE(_SOURCE_DIR/BINARY_DIR) 2026-08-09 10:43:01 -03:00
smtp netutils: smtp: treat recv EOF as an error 2026-07-09 09:29:57 +08:00
telnetc Remove unused header files across multiple source files 2025-01-10 21:42:00 +08:00
telnetd include/debug.h: Use <nuttx/debug.h> in apps 2026-04-11 10:39:27 -03:00
tftpc include/debug.h: Use <nuttx/debug.h> in apps 2026-04-11 10:39:27 -03:00
thttpd netutils/thttpd: Apply the same check to related allocation sites 2026-05-23 16:30:52 -04:00
wakaama cmake: Use NUTTX(_DIR/_BINARY_DIR) instead of CMAKE(_SOURCE_DIR/BINARY_DIR) 2026-08-09 10:43:01 -03:00
wakeonlan netutils: migrate the license to ASF 2024-12-21 13:53:10 +08:00
webclient include/debug.h: Use <nuttx/debug.h> in apps 2026-04-11 10:39:27 -03:00
webserver apps: Fix unchecked strdup()/asprintf() as requested in #1727 2026-05-23 16:30:52 -04:00
xedge netutils/xedge: refactor Makefile to use git clone instead of zip downloads 2025-08-02 10:00:20 -03:00
xmlrpc netutils: migrate the license to ASF 2024-12-21 13:53:10 +08:00
.gitignore build: Remve the unnecessary .gitignore 2020-05-23 15:56:35 +01:00
CMakeLists.txt netutils: migrate the license to ASF 2024-12-21 13:53:10 +08:00
Make.defs netutils: migrate the license to ASF 2024-12-21 13:53:10 +08:00
Makefile netutils: migrate the license to ASF 2024-12-21 13:53:10 +08:00