mirror of
https://github.com/apache/nuttx-apps.git
synced 2026-08-02 04:39:01 +00:00
Now that time_t is unconditionally 64-bit (signed int64_t) and the
struct timespec fields tv_sec / tv_nsec are wide enough on their own,
the explicit (uint64_t)/(int64_t)/(int) casts that used to guard the
multiplications and subtractions in *_us / *_ms / *_ns helpers are no
longer needed. Drop them to keep the timekeeping math readable.
In the same spirit, this commit also normalises the printf-style format
specifiers and casts used to print tv_sec / tv_nsec / tv_usec values.
The prior code was a mix of "%d"/"%u"/"%ld"/"%lu"/"%lld" with matching
(int)/(unsigned long)/(long long) casts; some formats truncated time_t
on 32-bit hosts, others mismatched signedness or width. Replace all
such cases with the portable POSIX-recommended forms:
- tv_sec (time_t, signed, impl-defined width) -> %jd + (intmax_t)
- tv_nsec (long, signed) -> %ld (no cast)
- tv_usec (suseconds_t / long) -> %ld (no cast)
Also drop two stale `(FAR const time_t *)&ts.tv_sec` casts that are
unnecessary now that ts.tv_sec is plain time_t.
Arithmetic-cleanup files (existing scope):
- benchmarks/cyclictest/cyclictest.c: timediff_us()
- benchmarks/sd_bench/sd_bench_main.c: get_time_delta_us()
- examples/oneshot/oneshot_main.c: maxus computation
- examples/watchdog/watchdog_main.c: current_time_ms (x2)
- industry/nxmodbus/nxmb_internal.h: nxmb_util_clock_ms()
- netutils/ntpclient/ntpclient.c: timespec2ntp()
- netutils/ptpd/ptpd.c: ptp_adjtime()
- system/dd/dd_main.c: elapsed accounting
- testing/drivers/drivertest/drivertest_posix_timer.c:
get_timestamp()
- testing/drivers/sd_stress/sd_stress_main.c:get_time_delta()
- testing/sched/getprime/getprime_main.c: elapsed accounting
- testing/sched/pthread_mutex_perf/pthread_mutex_perf.c:
timespec_avg()
Printf-format-fix files (new in this revision):
- examples/adjtime/adjtime_main.c
- examples/charger/charger_main.c
- examples/netpkt/netpkt_ethercat.c
- fsutils/mkfatfs/mkfatfs.c
- graphics/tiff/tiff_initialize.c
- netutils/ptpd/ptpd.c
- nshlib/nsh_timcmds.c
- system/coredump/coredump.c
- system/ptpd/ptpd_main.c
- testing/drivers/drivertest/drivertest_oneshot.c
- testing/mm/kasantest/kasantest.c
- testing/ostest/semtimed.c
- testing/sched/pthread_mutex_perf/pthread_mutex_perf.c
- testing/sched/timerjitter/timerjitter.c
- testing/testsuites/kernel/time/cases/clock_test_clock01.c
- testing/testsuites/kernel/time/cases/clock_test_smoke.c
No behavioural change.
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
179 lines
4.4 KiB
C
179 lines
4.4 KiB
C
/****************************************************************************
|
|
* apps/testing/testsuites/kernel/syscall/cases/write_test.c
|
|
*
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*
|
|
* Licensed to the Apache Software Foundation (ASF) under one or more
|
|
* contributor license agreements. See the NOTICE file distributed with
|
|
* this work for additional information regarding copyright ownership. The
|
|
* ASF licenses this file to you under the Apache License, Version 2.0 (the
|
|
* "License"); you may not use this file except in compliance with the
|
|
* License. You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
* License for the specific language governing permissions and limitations
|
|
* under the License.
|
|
*
|
|
****************************************************************************/
|
|
|
|
/****************************************************************************
|
|
* Included Files
|
|
****************************************************************************/
|
|
#include <nuttx/config.h>
|
|
#include <stdio.h>
|
|
#include <unistd.h>
|
|
#include <fcntl.h>
|
|
#include <syslog.h>
|
|
#include <inttypes.h>
|
|
#include <stdint.h>
|
|
#include <stdarg.h>
|
|
#include <stddef.h>
|
|
#include <setjmp.h>
|
|
#include <cmocka.h>
|
|
#include "SyscallTest.h"
|
|
|
|
/****************************************************************************
|
|
* Public Functions
|
|
****************************************************************************/
|
|
|
|
/****************************************************************************
|
|
* Name: test_nuttx_syscall_write01
|
|
****************************************************************************/
|
|
|
|
void test_nuttx_syscall_write01(FAR void **state)
|
|
{
|
|
ssize_t ret;
|
|
char filename[64];
|
|
int fd;
|
|
int i;
|
|
int badcount = 0;
|
|
char buf[BUFSIZ];
|
|
|
|
sprintf(filename, "%s_file", __func__);
|
|
|
|
/* setup */
|
|
|
|
fd = open(filename, O_RDWR | O_CREAT, 0700);
|
|
assert_true(fd > 0);
|
|
|
|
/* do test */
|
|
|
|
assert_non_null(memset(buf, 'w', BUFSIZ));
|
|
|
|
assert_int_equal(lseek(fd, 0, SEEK_SET), 0);
|
|
|
|
for (i = BUFSIZ; i > 0; i--)
|
|
{
|
|
ret = write(fd, buf, i);
|
|
if (ret == -1)
|
|
{
|
|
fail_msg("FAIL, write failed !\n");
|
|
break;
|
|
}
|
|
|
|
if (ret != i)
|
|
{
|
|
badcount++;
|
|
syslog(LOG_INFO,
|
|
"INFO, write() returned %zd, expected %d\n",
|
|
ret, i);
|
|
}
|
|
}
|
|
|
|
if (badcount != 0)
|
|
{
|
|
fail_msg("FAIL, write() failed to return proper count\n");
|
|
}
|
|
|
|
if (fd > 0)
|
|
{
|
|
assert_int_equal(close(fd), 0);
|
|
}
|
|
|
|
assert_int_equal(unlink(filename), 0);
|
|
}
|
|
|
|
/****************************************************************************
|
|
* Name: test_nuttx_syscall_write02
|
|
****************************************************************************/
|
|
|
|
void test_nuttx_syscall_write02(FAR void **state)
|
|
{
|
|
int fd;
|
|
int ret;
|
|
char filename[64];
|
|
sprintf(filename, "%s_file", __func__);
|
|
fd = open(filename, O_RDWR | O_CREAT, 0700);
|
|
assert_true(fd > 0);
|
|
|
|
ret = write(fd, NULL, 3);
|
|
assert_true(ret < 0);
|
|
|
|
if (fd > 0)
|
|
{
|
|
assert_int_equal(close(fd), 0);
|
|
}
|
|
|
|
assert_int_equal(unlink(filename), 0);
|
|
}
|
|
|
|
/****************************************************************************
|
|
* Name: test_nuttx_syscall_write03
|
|
****************************************************************************/
|
|
|
|
void test_nuttx_syscall_write03(FAR void **state)
|
|
{
|
|
int fd;
|
|
ssize_t ret;
|
|
char filename[64];
|
|
int i;
|
|
int badcount = 0;
|
|
char buf[100];
|
|
|
|
sprintf(filename, "%s_file.wav", __func__);
|
|
|
|
/* setup */
|
|
|
|
fd = open(filename, O_RDWR | O_CREAT, 0700);
|
|
assert_true(fd > 0);
|
|
|
|
/* do test */
|
|
|
|
assert_non_null(memset(buf, 'w', 100));
|
|
|
|
assert_int_equal(lseek(fd, 0, SEEK_SET), 0);
|
|
|
|
for (i = 100; i > 0; i--)
|
|
{
|
|
ret = write(fd, buf, i);
|
|
if (ret == -1)
|
|
{
|
|
fail_msg("FAIL, write failed !\n");
|
|
break;
|
|
}
|
|
|
|
if (ret != i)
|
|
{
|
|
badcount++;
|
|
syslog(LOG_INFO,
|
|
"INFO, write() returned %zd, expected %d\n",
|
|
ret, i);
|
|
}
|
|
}
|
|
|
|
if (badcount != 0)
|
|
{
|
|
fail_msg("FAIL, write() failed to return proper count\n");
|
|
}
|
|
|
|
if (fd > 0)
|
|
{
|
|
assert_int_equal(close(fd), 0);
|
|
}
|
|
|
|
assert_int_equal(unlink(filename), 0);
|
|
}
|