Commit graph

14 commits

Author SHA1 Message Date
Old-Ding
0566af556a examples: lp503x: Fix command argument handling
The lp503x shell command handlers receive the remaining input string as their argument. Treat empty colour arguments as the query case, document that query form in help text, and keep colour and brightness values signed until the existing range checks have run so invalid values are not silently truncated.

Guard the readline_stream() result before using it as a buffer index. readline_stream() returns EOF on end of file or failure, and writing buffer[len] before checking len can write before the stack buffer.

Use MAX_BRIGHTNESS consistently for brightness range checks.

Signed-off-by: Old-Ding <ai.neo.ae86@gmail.com>
2026-07-09 09:41:15 +08:00
Nightt
fcd10aa725 examples/lp503x: Open device write-only.
Open the LP503X device with O_WRONLY because the driver registers the device node with write-only permissions and the example controls it through ioctl().

Signed-off-by: Nightt <87569709+nightt5879@users.noreply.github.com>
2026-05-22 13:39:04 +08:00
Nightt
b4f1e29494 apps: Fix additional open() arguments.
Add missing mode arguments to direct open() calls that use O_CREAT.

Also open the lp503x device with explicit read-only flags instead of O_CREAT, matching the device-node usage.

Signed-off-by: Nightt <87569709+nightt5879@users.noreply.github.com>
2026-05-22 13:39:04 +08:00
zhangshoukui
4685ca557b lp503x_main: Minor fix
Signed-off-by: zhangshoukui <zhangshoukui@xiaomi.com>
2025-01-16 22:48:45 +08:00
chao an
66231194be apps/system: replace CONFIG_NSH_LINELEN to LINE_MAX
Applications should not depend on any properties of nshlib

Signed-off-by: chao an <anchao@lixiang.com>
2025-01-14 19:31:54 +08:00
zhangshoukui
d404b846f9 examples: Add depends on
Signed-off-by: zhangshoukui <zhangshoukui@xiaomi.com>
2025-01-03 21:28:20 +08:00
Alin Jerpelea
a91768e715 examples: migrate to SPDX identifier
Most tools used for compliance and SBOM generation use SPDX identifiers
This change brings us a step closer to an easy SBOM generation.

Signed-off-by: Alin Jerpelea <alin.jerpelea@sony.com>
2024-12-30 18:02:50 +08:00
simbit18
2bff210cdf /examples/lp503x: Removed the execute permissions. 2024-05-09 23:47:14 +08:00
chao an
929f1009c7 system/readline: correct the readline(3) prototype
Reference:
https://man.openbsd.org/readline.3

Signed-off-by: chao an <anchao@xiaomi.com>
2023-10-16 22:04:18 +08:00
xuxin19
32b417a8f7 cmake:refine cmake build for apps/examples
Signed-off-by: xuxin19 <xuxin19@xiaomi.com>
2023-08-17 01:15:17 +08:00
simbit18
88b01447b5 apps/examples/lp503x/Makefile: Fix mistakes in comments
Fix mistakes in comments
2023-03-04 01:43:03 +08:00
Xiang Xiao
21bc466a2b Remove the tail space char from all files
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2023-03-03 00:18:36 +02:00
Xiang Xiao
a29d9ea9da fsutils/examples: Include unistd.h explicitly
to get the prototypes or macros are defined in it

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2023-02-05 08:46:59 +02:00
TimJTi
9d1a70af86 Add example app for LP503x LED driver
Update examples/lp503x/lp503x_main.c

Move struct lp503x_cmd_s to private types section

Update examples/lp503x/lp503x_main.c

Update examples/lp503x/lp503x_main.c

Update examples/lp503x/lp503x_main.c

Update examples/lp503x/lp503x_main.c

Update examples/lp503x/lp503x_main.c

Update examples/lp503x/lp503x_main.c

Update examples/lp503x/lp503x_main.c

Update examples/lp503x/lp503x_main.c

Update examples/lp503x/lp503x_main.c

Update examples/lp503x/lp503x_main.c

Update examples/lp503x/lp503x_main.c

Update examples/lp503x/lp503x_main.c

Update examples/lp503x/lp503x_main.c

Update examples/lp503x/lp503x_main.c

Update examples/lp503x/lp503x_main.c

Update examples/lp503x/lp503x_main.c

Update examples/lp503x/lp503x_main.c

Update examples/lp503x/lp503x_main.c

Co-Authored-By: Petro Karashchenko <petro.karashchenko@gmail.com>
2022-12-30 21:19:33 +08:00