From f6462111b7a293b301b5b8305da5996af1afd5dd Mon Sep 17 00:00:00 2001 From: wangjianyu3 Date: Thu, 16 Jan 2025 22:59:29 +0800 Subject: [PATCH] apps/nshlib: Reuse local variable for cmd_memdump Signed-off-by: wangjianyu3 --- nshlib/nsh_mmcmds.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/nshlib/nsh_mmcmds.c b/nshlib/nsh_mmcmds.c index 9cbd01ce0..b11067098 100644 --- a/nshlib/nsh_mmcmds.c +++ b/nshlib/nsh_mmcmds.c @@ -60,7 +60,6 @@ int cmd_free(FAR struct nsh_vtbl_s *vtbl, int argc, FAR char **argv) int cmd_memdump(FAR struct nsh_vtbl_s *vtbl, int argc, FAR char **argv) { FAR char *arg; - int ret; int i; arg = lib_get_tempbuffer(LINE_MAX); @@ -78,10 +77,10 @@ int cmd_memdump(FAR struct nsh_vtbl_s *vtbl, int argc, FAR char **argv) else if (argc >= 2 && (strcmp(argv[1], "-h") == 0 || strcmp(argv[1], "help") == 0)) { - ret = nsh_catfile(vtbl, argv[0], - CONFIG_NSH_PROC_MOUNTPOINT "/memdump"); + i = nsh_catfile(vtbl, argv[0], + CONFIG_NSH_PROC_MOUNTPOINT "/memdump"); lib_put_tempbuffer(arg); - return ret; + return i; } else { @@ -95,10 +94,10 @@ int cmd_memdump(FAR struct nsh_vtbl_s *vtbl, int argc, FAR char **argv) } } - ret = nsh_writefile(vtbl, argv[0], arg, strlen(arg), - CONFIG_NSH_PROC_MOUNTPOINT "/memdump"); + i = nsh_writefile(vtbl, argv[0], arg, strlen(arg), + CONFIG_NSH_PROC_MOUNTPOINT "/memdump"); lib_put_tempbuffer(arg); - return ret; + return i; } #endif /* !CONFIG_NSH_DISABLE_MEMDUMP && NSH_HAVE_WRITEFILE */