Aksal/nuttx-apps
1
0
Fork 1
mirror of https://github.com/apache/nuttx-apps.git synced 2026-08-01 20:29:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

netlib_xarp: remove redundant cast

Browse source 
removes redundant type casts in ARP-related network library functions.
The casts from req.arp_dev (already a char array) to (FAR char *)
are unnecessary and can be safely removed.

Signed-off-by: zhanghongyu <zhanghongyu@xiaomi.com>
This commit is contained in:
zhanghongyu 2024-12-23 13:42:20 +08:00 • committed by Xiang Xiao
parent bb9229de06
commit d48b45000d
4 changed files with 4 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

3
netutils/netlib/netlib_delarp.c
View file

@ -76,8 +76,7 @@ int netlib_del_arpmapping(FAR const struct sockaddr_in *inaddr,
memset(&req.arp_ha, 0, sizeof(struct sockaddr_in));
if (ifname != NULL)
{
strlcpy((FAR char *)&req.arp_dev, ifname,
sizeof(req.arp_dev));
strlcpy(req.arp_dev, ifname, sizeof(req.arp_dev));
}
else
{

3
netutils/netlib/netlib_getarp.c
View file

@ -77,8 +77,7 @@ int netlib_get_arpmapping(FAR const struct sockaddr_in *inaddr,
memcpy(&req.arp_pa, inaddr, sizeof(struct sockaddr_in));
if (ifname != NULL)
{
strlcpy((FAR char *)&req.arp_dev, ifname,
sizeof(req.arp_dev));
strlcpy(req.arp_dev, ifname, sizeof(req.arp_dev));
}
else
{

3
netutils/netlib/netlib_setarp.c
View file

@ -81,8 +81,7 @@ int netlib_set_arpmapping(FAR const struct sockaddr_in *inaddr,
req.arp_flags = ATF_PERM;
if (ifname != NULL)
{
strlcpy((FAR char *)&req.arp_dev, ifname,
sizeof(req.arp_dev));
strlcpy(req.arp_dev, ifname, sizeof(req.arp_dev));
}
else
{

2
nshlib/nsh_netcmds.c
View file

@ -1310,7 +1310,7 @@ int cmd_arp(FAR struct nsh_vtbl_s *vtbl, int argc, FAR char **argv)
FAR uint8_t *ptr;
if (ifname != NULL &&
strcmp(ifname, (FAR char *)arptab[i].arp_dev) != 0)
strcmp(ifname, arptab[i].arp_dev) != 0)
{
continue;
}