Aksal/nuttx-apps
1
0
Fork 1
mirror of https://github.com/apache/nuttx-apps.git synced 2026-08-01 20:29:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

system/popen: close newfd correctly

Browse source 
Fixes a bug where newfd is not properly closed when newfd[0] equals newfd[1].
This can cause file descriptor leaks in certain edge cases where the read
and write sides of the pipe are duplicated.

Signed-off-by: hongfengchen <hongfengchen@xiaomi.com>
This commit is contained in:
hongfengchen 2025-06-10 15:03:17 +08:00 • committed by Donny(董九柱)
parent f16a45a854
commit b72f7997a3
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
system/popen/popen.c
View file

@ -312,7 +312,7 @@ FILE *popen(FAR const char *command, FAR const char *mode)
close(newfd[0]);
if (rw)
if (rw && newfd[0] != newfd[1])
{
close(newfd[1]);
}