From 7cacd569e5b30db8ca85f45dc8492dc3195f4086 Mon Sep 17 00:00:00 2001 From: YAMAMOTO Takashi Date: Sat, 22 Jul 2023 23:13:08 +0900 Subject: [PATCH] Revert "toywasm: disable tail call and explain why" This reverts commit fcda92ebc7e77b5d302c322d202a85044713dd0d. because it isn't necessary for the latest versions of toywasm. --- interpreters/toywasm/regen.sh | 8 -------- 1 file changed, 8 deletions(-) diff --git a/interpreters/toywasm/regen.sh b/interpreters/toywasm/regen.sh index 5d93bad5d..361a3bdcb 100755 --- a/interpreters/toywasm/regen.sh +++ b/interpreters/toywasm/regen.sh @@ -18,16 +18,8 @@ git -C ${DIR} checkout FETCH_HEAD # Note: for this build, TOYWASM_USE_SHORT_ENUMS is only used for # the "toywasm --version" output. -# Note: Disable TOYWASM_USE_TAILCALL because it isn't safe for some -# targets and/or compilers. For example, xtensa windowed ABI doesn't -# allow tail call optimization. (At least it isn't straightforward -# unless frame sizes of the caller and the callee happens to match.) -# REVISIT: This should probably be a Kconfig knob. For now, disable -# it globally. - cmake -B ${BUILDDIR} \ -DTOYWASM_USE_SHORT_ENUMS=OFF \ --DTOYWASM_USE_TAILCALL=OFF \ -DTOYWASM_ENABLE_WASM_EXTENDED_CONST=ON \ -DTOYWASM_ENABLE_WASM_MULTI_MEMORY=ON \ -DTOYWASM_ENABLE_WASM_TAILCALL=ON \