From 74aa0f21c5dfb54e8e40d4f2c561dd3da2f9a23c Mon Sep 17 00:00:00 2001 From: Gregory Nutt Date: Sun, 5 Jul 2015 09:06:13 -0600 Subject: [PATCH] NSH uname command: Uninitialized variable caused failures in some unlucky cases --- nshlib/nsh_syscmds.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/nshlib/nsh_syscmds.c b/nshlib/nsh_syscmds.c index 54a6d8261..0874046eb 100644 --- a/nshlib/nsh_syscmds.c +++ b/nshlib/nsh_syscmds.c @@ -239,7 +239,9 @@ int cmd_uname(FAR struct nsh_vtbl_s *vtbl, int argc, char **argv) /* Get the ping options */ - set = 0; + set = 0; + badarg = false; + while ((option = getopt(argc, argv, "asonrvmpi")) != ERROR) { switch (option) @@ -334,7 +336,6 @@ int cmd_uname(FAR struct nsh_vtbl_s *vtbl, int argc, char **argv) case 1: /* Print noname */ str = info.nodename; break; - #endif case 2: /* Print the kernel release */ str = info.release;