From 39bd365787d2a3666173c3b6fcf129ccfdc3ad01 Mon Sep 17 00:00:00 2001 From: wangjianyu3 Date: Wed, 18 Dec 2024 17:32:06 +0800 Subject: [PATCH] nshlib/nsh_parse: Removing unnecessary value assigning about redirection Coverity Log CID 1612757: (#1 of 1): UNUSED_VALUE assigned_value: The value -1 is assigned to param.fd_in here, but the stored value is overwritten before it can be used. Signed-off-by: wangjianyu3 --- nshlib/nsh_parse.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/nshlib/nsh_parse.c b/nshlib/nsh_parse.c index e75b7937e..f6bff1b29 100644 --- a/nshlib/nsh_parse.c +++ b/nshlib/nsh_parse.c @@ -2739,16 +2739,12 @@ static int nsh_parse_command(FAR struct nsh_vtbl_s *vtbl, FAR char *cmdline) if (param.fd_in != -1) { close(param.fd_in); - param.fd_in = -1; vtbl->np.np_redir_in = redirect_in_save; } - if (param.fd_out != -1) - { - close(param.fd_out); - param.fd_out = -1; - vtbl->np.np_redir_out = redirect_out_save; - } + close(param.fd_out); + param.fd_out = -1; + vtbl->np.np_redir_out = redirect_out_save; redirect_in_save = vtbl->np.np_redir_in; vtbl->np.np_redir_in = true;