From 2b2c4805a4bca19b4798c03c7637a4c7d8a2c757 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E7=94=B0=E6=98=95?= Date: Tue, 10 Jan 2023 20:10:52 +0800 Subject: [PATCH] netutils/dhcpc:fix dhcp hostname len error in dhcpc_sendmsg MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: 田昕 --- netutils/dhcpc/dhcpc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/netutils/dhcpc/dhcpc.c b/netutils/dhcpc/dhcpc.c index 92f484364..0d509456a 100644 --- a/netutils/dhcpc/dhcpc.c +++ b/netutils/dhcpc/dhcpc.c @@ -231,7 +231,7 @@ static FAR uint8_t *dhcpc_addend(FAR uint8_t *optptr) static int dhcpc_sendmsg(FAR struct dhcpc_state_s *pdhcpc, FAR struct dhcpc_state *presult, int msgtype) { - char hostname[HOST_NAME_MAX]; + char hostname[HOST_NAME_MAX + 1]; struct sockaddr_in addr; FAR uint8_t *pend; in_addr_t serverid = INADDR_BROADCAST; @@ -257,7 +257,7 @@ static int dhcpc_sendmsg(FAR struct dhcpc_state_s *pdhcpc, if (gethostname(hostname, sizeof(hostname)) || (0 == strlen(hostname))) { - strncpy(hostname, CONFIG_NETUTILS_DHCPC_HOST_NAME, HOST_NAME_MAX); + strlcpy(hostname, CONFIG_NETUTILS_DHCPC_HOST_NAME, sizeof(hostname)); } /* Handle the message specific settings */